From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] M68k wd33c93 locking
Date: Sat, 26 Jul 2003 16:51:29 +0200 [thread overview]
Message-ID: <200307261451.h6QEpT9s002280@callisto.of.borg> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]
M68k wd33c93: host_lock is a pointer to a spinlock, not a spinlock (from Ralf
Bächle)
--- linux-2.6.x/drivers/scsi/a2091.c Fri May 9 10:21:34 2003
+++ linux-m68k-2.6.x/drivers/scsi/a2091.c Fri Jun 6 13:33:13 2003
@@ -43,9 +43,9 @@
continue;
if (status & ISTR_INTS) {
- spin_lock_irqsave(&instance->host_lock, flags);
+ spin_lock_irqsave(instance->host_lock, flags);
wd33c93_intr (instance);
- spin_unlock_irqrestore(&instance->host_lock, flags);
+ spin_unlock_irqrestore(instance->host_lock, flags);
handled = 1;
}
}
--- linux-2.6.x/drivers/scsi/a3000.c Fri May 9 10:21:34 2003
+++ linux-m68k-2.6.x/drivers/scsi/a3000.c Fri Jun 6 13:33:13 2003
@@ -36,9 +36,9 @@
return IRQ_NONE;
if (status & ISTR_INTS)
{
- spin_lock_irqsave(&a3000_host->host_lock, flags);
+ spin_lock_irqsave(a3000_host->host_lock, flags);
wd33c93_intr (a3000_host);
- spin_unlock_irqrestore(&a3000_host->host_lock, flags);
+ spin_unlock_irqrestore(a3000_host->host_lock, flags);
return IRQ_HANDLED;
}
printk("Non-serviced A3000 SCSI-interrupt? ISTR = %02x\n", status);
--- linux-2.6.x/drivers/scsi/gvp11.c Fri May 9 10:21:34 2003
+++ linux-m68k-2.6.x/drivers/scsi/gvp11.c Fri Jun 6 13:33:18 2003
@@ -42,9 +42,9 @@
if (!(status & GVP11_DMAC_INT_PENDING))
continue;
- spin_lock_irqsave(&instance->host_lock, flags);
+ spin_lock_irqsave(instance->host_lock, flags);
wd33c93_intr (instance);
- spin_unlock_irqrestore(&instance->host_lock, flags);
+ spin_unlock_irqrestore(instance->host_lock, flags);
handled = 1;
}
return IRQ_RETVAL(handled);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2003-07-26 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-26 14:51 Geert Uytterhoeven [this message]
2003-07-28 8:49 ` [PATCH] M68k wd33c93 locking Jan-Benedict Glaw
2003-07-30 20:59 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307261451.h6QEpT9s002280@callisto.of.borg \
--to=geert@linux-m68k.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).