From: "tip-bot for akpm@linux-foundation.org" <akpm@linux-foundation.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
akpm@linux-foundation.org, tglx@linutronix.de,
mhiramat@redhat.com, mingo@elte.hu
Subject: [tip:x86/urgent] x86: Fix objdump version check in arch/x86/tools/chkobjdump.awk
Date: Thu, 17 Dec 2009 23:57:53 GMT [thread overview]
Message-ID: <tip-8c63450718ea62ee3a70bffde170b4d15fc72d3c@git.kernel.org> (raw)
In-Reply-To: <200912172326.nBHNQaQl024796@imap1.linux-foundation.org>
Commit-ID: 8c63450718ea62ee3a70bffde170b4d15fc72d3c
Gitweb: http://git.kernel.org/tip/8c63450718ea62ee3a70bffde170b4d15fc72d3c
Author: akpm@linux-foundation.org <akpm@linux-foundation.org>
AuthorDate: Thu, 17 Dec 2009 15:26:36 -0800
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Thu, 17 Dec 2009 15:34:29 -0800
x86: Fix objdump version check in arch/x86/tools/chkobjdump.awk
It says
Warning: objdump version is older than 2.19
Warning: Skipping posttest.
because it used the wrong field from `objdump -v':
akpm:/usr/src/25> /opt/crosstool/gcc-4.0.2-glibc-2.3.6/x86_64-unknown-linux-gnu/bin/x86_64-unknown-linux-gnu-objdump -v
GNU objdump 2.16.1
Copyright 2005 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License. This program has absolutely no warranty.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <200912172326.nBHNQaQl024796@imap1.linux-foundation.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Masami Hiramatsu <mhiramat@redhat.com>
---
arch/x86/tools/chkobjdump.awk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/tools/chkobjdump.awk b/arch/x86/tools/chkobjdump.awk
index 0d13cd9..5bbb5a3 100644
--- a/arch/x86/tools/chkobjdump.awk
+++ b/arch/x86/tools/chkobjdump.awk
@@ -9,7 +9,7 @@ BEGIN {
}
/^GNU/ {
- split($4, ver, ".");
+ split($3, ver, ".");
if (ver[1] > od_ver ||
(ver[1] == od_ver && ver[2] >= od_sver)) {
exit 1;
next parent reply other threads:[~2009-12-17 23:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200912172326.nBHNQaQl024796@imap1.linux-foundation.org>
2009-12-17 23:57 ` tip-bot for akpm@linux-foundation.org [this message]
2009-12-18 0:04 ` [tip:x86/urgent] x86: Fix objdump version check in arch/x86/tools/chkobjdump.awk Masami Hiramatsu
2009-12-18 0:07 ` H. Peter Anvin
2009-12-18 0:18 ` Masami Hiramatsu
2009-12-18 0:25 ` H. Peter Anvin
2009-12-18 15:34 ` [PATCH x86/urgent] x86: Fix objdump version check in chkobjdump.awk for different formats Masami Hiramatsu
2009-12-18 15:32 ` Masami Hiramatsu
2009-12-18 15:40 ` [PATCH x86/urgent v2] " Masami Hiramatsu
2009-12-18 18:06 ` [tip:x86/urgent] " tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8c63450718ea62ee3a70bffde170b4d15fc72d3c@git.kernel.org \
--to=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).