From: Arnd Bergmann <arnd@arndb.de>
To: "Michael S. Tsirkin" <m.s.tsirkin@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
neilb@suse.de, linux-raid@vger.kernel.org, dm-devel@redhat.com,
maan@systemlinux.org
Subject: compat_ioctl: ignore RAID_VERSION ioctl
Date: Sat, 30 Jan 2010 23:02:10 +0100 [thread overview]
Message-ID: <201001302302.10574.arnd@arndb.de> (raw)
In-Reply-To: <20100130205353.GA3168@redhat.com>
md ioctls are now handled by the md driver itself, but mdadm
may call RAID_VERSION on other devices as well. Mark the command
as IGNORE_IOCTL so this fails silently rather than printing
an annoying message.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
On Saturday 30 January 2010, Michael S. Tsirkin wrote:
> Under 2.6.33-rcX (at least rc5 and rc6, didn't check earlier versions),
> I started seeing these messages in dmesg (I do not see these messages on 2.6.32):
>
> [ 16.528951] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda9
Does this help?
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1038,6 +1038,8 @@ COMPATIBLE_IOCTL(FIOQSIZE)
#ifdef CONFIG_BLOCK
/* loop */
IGNORE_IOCTL(LOOP_CLR_FD)
+/* md calls this on random blockdevs */
+IGNORE_IOCTL(RAID_VERSION)
/* SG stuff */
COMPATIBLE_IOCTL(SG_SET_TIMEOUT)
COMPATIBLE_IOCTL(SG_GET_TIMEOUT)
next prev parent reply other threads:[~2010-01-30 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 20:53 2.6.33-rc6 regression: mdadm Unknown cmd 800c0910 (RAID_VERSION) Michael S. Tsirkin
2010-01-30 22:02 ` Arnd Bergmann [this message]
2010-01-31 9:03 ` compat_ioctl: ignore RAID_VERSION ioctl Michael S. Tsirkin
2010-02-07 9:24 ` Michael S. Tsirkin
2010-02-07 10:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001302302.10574.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=m.s.tsirkin@gmail.com \
--cc=maan@systemlinux.org \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).