From: Herbert Xu <herbert@gondor.apana.org.au>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [AMD76X]
Date: Sun, 24 Aug 2003 09:33:23 +1000 [thread overview]
Message-ID: <20030823233323.GA7989@gondor.apana.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
Hi:
amd76x_pm.c will crash if no chipsets are found and CONFIG_HOTPLUG is
turned on. This patch makes it return with a failure instead.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 1045 bytes --]
Index: kernel-source-2.4/drivers/char/amd76x_pm.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/drivers/char/amd76x_pm.c,v
retrieving revision 1.2
diff -u -r1.2 amd76x_pm.c
--- kernel-source-2.4/drivers/char/amd76x_pm.c 1 Dec 2002 05:52:05 -0000 1.2
+++ kernel-source-2.4/drivers/char/amd76x_pm.c 23 Aug 2003 23:30:11 -0000
@@ -577,16 +577,18 @@
int found;
/* Find northbridge */
- found = pci_module_init(&amd_nb_driver);
- if (found < 0) {
+ found = pci_register_driver(&amd_nb_driver);
+ if (found <= 0) {
printk(KERN_ERR "amd76x_pm: Could not find northbridge\n");
+ pci_unregister_driver(&amd_nb_driver);
return 1;
}
/* Find southbridge */
- found = pci_module_init(&amd_sb_driver);
- if (found < 0) {
+ found = pci_register_driver(&amd_sb_driver);
+ if (found <= 0) {
printk(KERN_ERR "amd76x_pm: Could not find southbridge\n");
+ pci_unregister_driver(&amd_sb_driver);
pci_unregister_driver(&amd_nb_driver);
return 1;
}
next reply other threads:[~2003-08-23 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-23 23:33 Herbert Xu [this message]
2003-08-24 17:53 ` [AMD76X] Willy Tarreau
2003-08-25 8:12 ` [AMD76X] Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030823233323.GA7989@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).