From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Linux Fbdev <linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] fb_cmap and transparency
Date: Fri, 29 Aug 2003 16:49:45 +0200 [thread overview]
Message-ID: <200308291449.h7TEnjX7005827@callisto.of.borg> (raw)
If a colormap contains no transparency information, fb_set_cmap() calls
fb_setcolreg() with trans = 0. This causes all CLUT entries to be fully
transparent on hardware that does have transparency information in the CLUT
registers.
The following patch solves this problem by changing the default transparency
from 0 (full transparent) to 0xffff (full opaque).
--- linux-2.4.23-pre1/drivers/video/fbcmap.c.orig Mon Mar 5 09:29:30 2001
+++ linux-2.4.23-pre1/drivers/video/fbcmap.c Mon Mar 17 17:39:59 2003
@@ -271,7 +271,7 @@
hred = *red;
hgreen = *green;
hblue = *blue;
- htransp = transp ? *transp : 0;
+ htransp = transp ? *transp : 0xffff;
} else {
get_user(hred, red);
get_user(hgreen, green);
@@ -279,7 +279,7 @@
if (transp)
get_user(htransp, transp);
else
- htransp = 0;
+ htransp = 0xffff;
}
red++;
green++;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2003-08-29 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-29 14:49 Geert Uytterhoeven [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-06-15 19:10 [PATCH] fb_cmap and transparency Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308291449.h7TEnjX7005827@callisto.of.borg \
--to=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).