From: Stephen Hemminger <shemminger@osdl.org>
To: Philip.Blundell@pobox.com, Frodo Looijaard <frodol@dds.nl>,
Philip Edelbrock <phil@netroedge.com>, Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] video/saa5249.c, video/tuner-3036.c get rid of MOD_INC/DEC
Date: Tue, 9 Sep 2003 16:09:26 -0700 [thread overview]
Message-ID: <20030909160926.09c5fa69.shemminger@osdl.org> (raw)
Get rid of MOD_INC/DEC since ref count comes from owner field on I2C
for these drivers.
Not sure who is maintaining these, maybe no one because they haven't been
purged of MOD stuff yet.
diff -Nru a/drivers/media/video/saa5249.c b/drivers/media/video/saa5249.c
--- a/drivers/media/video/saa5249.c Tue Sep 9 16:04:52 2003
+++ b/drivers/media/video/saa5249.c Tue Sep 9 16:04:52 2003
@@ -214,7 +214,6 @@
}
t->client = client;
i2c_attach_client(client);
- MOD_INC_USE_COUNT;
return 0;
}
@@ -237,7 +236,6 @@
kfree(vd->priv);
kfree(vd);
kfree(client);
- MOD_DEC_USE_COUNT;
return 0;
}
diff -Nru a/drivers/media/video/tuner-3036.c b/drivers/media/video/tuner-3036.c
--- a/drivers/media/video/tuner-3036.c Tue Sep 9 16:04:52 2003
+++ b/drivers/media/video/tuner-3036.c Tue Sep 9 16:04:52 2003
@@ -135,7 +135,6 @@
printk("tuner: SAB3036 found, status %02x\n", tuner_getstatus(client));
i2c_attach_client(client);
- MOD_INC_USE_COUNT;
if (i2c_master_send(client, buffer, 2) != 2)
printk("tuner: i2c i/o error 1\n");
@@ -149,7 +148,6 @@
static int
tuner_detach(struct i2c_client *c)
{
- MOD_DEC_USE_COUNT;
return 0;
}
reply other threads:[~2003-09-09 23:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030909160926.09c5fa69.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=Philip.Blundell@pobox.com \
--cc=frodol@dds.nl \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).