From: Will Drewry <wad@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>, Nick Piggin <npiggin@suse.de>,
Tejun Heo <tj@kernel.org>, Scott James Remnant <scott@ubuntu.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Harald Hoyer <harald@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
agk@redhat.com, snitzer@redhat.com,
Will Drewry <wad@chromium.org>
Subject: [PATCH 1/2] init: make the path argument a const in name_to_dev_t
Date: Tue, 25 May 2010 10:46:50 -0500 [thread overview]
Message-ID: <1274802411-26613-1-git-send-email-wad@chromium.org> (raw)
name_to_dev_t takes a char * argument which it never modifies. This
change converts it to a const char *.
(This is useful with the second patch in the series which exports the
symbol. External consumers of the function will now be able to pass in
a const char * without duping or casting away const-ness.)
Signed-off-by: Will Drewry <wad@chromium.org>
---
include/linux/mount.h | 2 +-
init/do_mounts.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mount.h b/include/linux/mount.h
index 4bd0547..ad819a0 100644
--- a/include/linux/mount.h
+++ b/include/linux/mount.h
@@ -134,6 +134,6 @@ extern int do_add_mount(struct vfsmount *newmnt, struct path *path,
extern void mark_mounts_for_expiry(struct list_head *mounts);
-extern dev_t name_to_dev_t(char *name);
+extern dev_t name_to_dev_t(const char *name);
#endif /* _LINUX_MOUNT_H */
diff --git a/init/do_mounts.c b/init/do_mounts.c
index 0848a5b..a322b13 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -75,7 +75,7 @@ __setup("rw", readwrite);
* bangs.
*/
-dev_t name_to_dev_t(char *name)
+dev_t name_to_dev_t(const char *name)
{
char s[32];
char *p;
--
1.7.0.4
next reply other threads:[~2010-05-25 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 15:46 Will Drewry [this message]
2010-05-25 15:46 ` [PATCH 2/2] init, mount: export the name_to_dev_t symbol Will Drewry
2010-05-25 15:55 ` Christoph Hellwig
2010-05-25 16:05 ` Alasdair G Kergon
2010-05-25 16:11 ` Will Drewry
2010-05-25 17:21 ` Christoph Hellwig
2010-05-25 18:30 ` Mike Snitzer
2010-06-08 16:02 ` Will Drewry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274802411-26613-1-git-send-email-wad@chromium.org \
--to=wad@chromium.org \
--cc=agk@redhat.com \
--cc=cl@linux-foundation.org \
--cc=harald@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=scott@ubuntu.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
--cc=vegard.nossum@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).