From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
"Borislav Petkov" <borislav.petkov@amd.com>,
"Toralf Förster" <toralf.foerster@gmx.de>,
user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH] x86, hweight: Fix UML boot crash
Date: Sun, 30 May 2010 19:03:46 +0200 [thread overview]
Message-ID: <20100530170346.GC1565@liondog.tnic> (raw)
In-Reply-To: <201005301728.25976.toralf.foerster@gmx.de>
Obviously UML cannot stomach callee reg-saving trickery
introduced with d61931d89be506372d01a90d1755f6d0a9fafe2d (x86:
Add optimized popcnt variants) and oopses during boot:
http://marc.info/?l=linux-kernel&m=127522065202435&w=2
Go ahead and fall back to the software hweight* routines on UML.
LKML-Reference: <201005271944.09541.toralf.foerster@gmx.de>
Tested-by: Toralf Förster <toralf.foerster@gmx.de>
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Borislav Petkov <bp@alien8.de>
---
arch/x86/include/asm/bitops.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h
index 545776e..c9dad12 100644
--- a/arch/x86/include/asm/bitops.h
+++ b/arch/x86/include/asm/bitops.h
@@ -444,7 +444,11 @@ static inline int fls(int x)
#define ARCH_HAS_FAST_MULTIPLIER 1
+#ifdef CONFIG_UML
+#include <asm-generic/bitops/arch_hweight.h>
+#else
#include <asm/arch_hweight.h>
+#endif
#include <asm-generic/bitops/const_hweight.h>
--
1.7.1
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2010-05-30 17:03 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 17:44 current git kernel crashes UML system during boot Toralf Förster
2010-05-30 11:39 ` Geert Uytterhoeven
2010-05-30 11:57 ` Geert Uytterhoeven
2010-05-30 15:02 ` Borislav Petkov
2010-05-30 15:18 ` Geert Uytterhoeven
2010-05-30 15:46 ` Borislav Petkov
2010-05-30 15:28 ` Toralf Förster
2010-05-30 17:03 ` Borislav Petkov [this message]
2010-05-30 18:36 ` [PATCH] x86, hweight: Fix UML boot crash H. Peter Anvin
2010-05-30 19:39 ` Borislav Petkov
2010-05-30 20:17 ` Borislav Petkov
2010-05-30 21:09 ` H. Peter Anvin
2010-06-12 13:34 ` [uml-devel] " Paolo Giarrusso
2010-06-12 14:18 ` Borislav Petkov
2010-06-12 16:01 ` Paolo Giarrusso
2010-06-12 16:34 ` Borislav Petkov
2010-06-12 18:37 ` Geert Uytterhoeven
2010-06-13 6:58 ` Borislav Petkov
2010-05-31 13:55 ` Toralf Förster
2010-05-31 14:10 ` Borislav Petkov
2010-05-31 14:36 ` Toralf Förster
2010-06-14 9:49 ` Toralf Förster
2010-06-14 10:26 ` [uml-devel] " Paolo Giarrusso
2010-06-14 12:54 ` Toralf Förster
2010-06-14 13:00 ` Borislav Petkov
2010-06-14 13:44 ` Toralf Förster
2010-06-14 14:39 ` Geert Uytterhoeven
2010-06-14 15:11 ` Toralf Förster
2010-06-14 15:20 ` H. Peter Anvin
2010-05-31 14:25 ` [uml-devel] " Boaz Harrosh
2010-05-31 2:32 ` Jeff Dike
2010-05-31 13:51 ` Borislav Petkov
2010-05-31 15:56 ` Jeff Dike
2010-05-31 16:29 ` Borislav Petkov
[not found] ` <tip-cc7f0a7b3004a4ca0bfef0e1ca79f2e0da6ca1b0@git.kernel.org>
2010-06-09 22:43 ` [tip:x86/urgent] " H. Peter Anvin
2010-06-10 5:32 ` Geert Uytterhoeven
2010-06-10 6:26 ` H. Peter Anvin
2010-06-09 8:04 ` [PATCH resend] um, " Boaz Harrosh
2010-06-09 8:09 ` [uml-devel] " Boaz Harrosh
2010-06-09 8:46 ` Geert Uytterhoeven
2010-06-09 9:08 ` Boaz Harrosh
2010-06-09 9:32 ` Américo Wang
2010-06-09 18:29 ` H. Peter Anvin
2010-06-14 16:08 ` Boaz Harrosh
2010-06-14 16:41 ` H. Peter Anvin
2010-06-14 18:18 ` Boaz Harrosh
2010-06-09 16:39 ` Boaz Harrosh
2010-06-10 23:43 ` [tip:x86/urgent] um, hweight: Fix UML boot crash due to x86 optimized hweight tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100530170346.GC1565@liondog.tnic \
--to=bp@alien8.de \
--cc=borislav.petkov@amd.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).