[QUOTA] Drop spin lock when calling request_module
diff mbox series

Message ID 20031105111025.GA2337@gondor.apana.org.au
State New, archived
Headers show
Series
  • [QUOTA] Drop spin lock when calling request_module
Related show

Commit Message

Herbert Xu Nov. 5, 2003, 11:10 a.m. UTC
Hi:

This patch drops the spin lock when calling request_module as the
latter will sleep.

Cheers,

Comments

Jan Kara Nov. 6, 2003, 4:18 p.m. UTC | #1
Hi,

> This patch drops the spin lock when calling request_module as the
> latter will sleep.
  The patch looks right. Linus please apply if you find it serious
enough (or Andrew please queue it up for next releases...)...

							Thanks
								Honza

Index: kernel-source-2.5/fs/dquot.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/fs/dquot.c,v
retrieving revision 1.3
diff -u -r1.3 dquot.c
--- kernel-source-2.5/fs/dquot.c	26 Oct 2003 03:20:37 -0000	1.3
+++ kernel-source-2.5/fs/dquot.c	5 Nov 2003 11:04:30 -0000
@@ -128,17 +128,21 @@
 	if (!actqf || !try_module_get(actqf->qf_owner)) {
 		int qm;
 
+		spin_unlock(&dq_list_lock);
+
 		for (qm = 0; module_names[qm].qm_fmt_id && module_names[qm].qm_fmt_id != id; qm++);
 		if (!module_names[qm].qm_fmt_id || request_module(module_names[qm].qm_mod_name)) {
 			actqf = NULL;
 			goto out;
 		}
+
+		spin_lock(&dq_list_lock);
 		for (actqf = quota_formats; actqf && actqf->qf_fmt_id != id; actqf = actqf->qf_next);
 		if (actqf && !try_module_get(actqf->qf_owner))
 			actqf = NULL;
 	}
-out:
 	spin_unlock(&dq_list_lock);
+out:
 	return actqf;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Linus Torvalds Nov. 6, 2003, 4:28 p.m. UTC | #2
On Thu, 6 Nov 2003, Jan Kara wrote:
>  			actqf = NULL;
>  			goto out;

Mind changing this to just a "return NULL" instead and just remove the
label entirely, now that it doesn't actually need to play with any
spinlocks?

I don't mind goto's if there is a _point_ to them, but this one doesn't 
seem to fall under that heading.

		Linus


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Jan Kara Nov. 6, 2003, 6:11 p.m. UTC | #3
> 
> On Thu, 6 Nov 2003, Jan Kara wrote:
> >  			actqf = NULL;
> >  			goto out;
> 
> Mind changing this to just a "return NULL" instead and just remove the
> label entirely, now that it doesn't actually need to play with any
> spinlocks?
> 
> I don't mind goto's if there is a _point_ to them, but this one doesn't 
> seem to fall under that heading.
  You're right. The nicer fix is attached.

									Honza

----------------------------Cut here--------------------------------------

diff -ruX ../kerndiffexclude linux-2.6.0-test9/fs/dquot.c linux-2.6.0-test9-loadfix/fs/dquot.c
--- linux-2.6.0-test9/fs/dquot.c	Sat Oct 25 20:44:03 2003
+++ linux-2.6.0-test9-loadfix/fs/dquot.c	Thu Nov  6 19:10:37 2003
@@ -128,16 +128,17 @@
 	if (!actqf || !try_module_get(actqf->qf_owner)) {
 		int qm;
 
+		spin_unlock(&dq_list_lock);
+		
 		for (qm = 0; module_names[qm].qm_fmt_id && module_names[qm].qm_fmt_id != id; qm++);
-		if (!module_names[qm].qm_fmt_id || request_module(module_names[qm].qm_mod_name)) {
-			actqf = NULL;
-			goto out;
-		}
+		if (!module_names[qm].qm_fmt_id || request_module(module_names[qm].qm_mod_name))
+			return NULL;
+
+		spin_lock(&dq_list_lock);
 		for (actqf = quota_formats; actqf && actqf->qf_fmt_id != id; actqf = actqf->qf_next);
 		if (actqf && !try_module_get(actqf->qf_owner))
 			actqf = NULL;
 	}
-out:
 	spin_unlock(&dq_list_lock);
 	return actqf;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

Index: kernel-source-2.5/fs/dquot.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/fs/dquot.c,v
retrieving revision 1.3
diff -u -r1.3 dquot.c
--- kernel-source-2.5/fs/dquot.c	26 Oct 2003 03:20:37 -0000	1.3
+++ kernel-source-2.5/fs/dquot.c	5 Nov 2003 11:04:30 -0000
@@ -128,17 +128,21 @@ 
 	if (!actqf || !try_module_get(actqf->qf_owner)) {
 		int qm;
 
+		spin_unlock(&dq_list_lock);
+
 		for (qm = 0; module_names[qm].qm_fmt_id && module_names[qm].qm_fmt_id != id; qm++);
 		if (!module_names[qm].qm_fmt_id || request_module(module_names[qm].qm_mod_name)) {
 			actqf = NULL;
 			goto out;
 		}
+
+		spin_lock(&dq_list_lock);
 		for (actqf = quota_formats; actqf && actqf->qf_fmt_id != id; actqf = actqf->qf_next);
 		if (actqf && !try_module_get(actqf->qf_owner))
 			actqf = NULL;
 	}
-out:
 	spin_unlock(&dq_list_lock);
+out:
 	return actqf;
 }