linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: neilb@cse.unsw.edu.au,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [LOCKD] Fix double module_put
Date: Mon, 17 Nov 2003 20:40:26 +1100	[thread overview]
Message-ID: <20031117094026.GA12562@gondor.apana.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

Hi:

This patch fixes a double module_put in lockd.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 667 bytes --]

Index: kernel-source-2.5/fs/lockd/clntlock.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/fs/lockd/clntlock.c,v
retrieving revision 1.1.1.3
diff -u -r1.1.1.3 clntlock.c
--- kernel-source-2.5/fs/lockd/clntlock.c	27 Jul 2003 17:09:35 -0000	1.1.1.3
+++ kernel-source-2.5/fs/lockd/clntlock.c	17 Nov 2003 09:37:40 -0000
@@ -188,7 +188,7 @@
 		nlmclnt_prepare_reclaim(host, newstate);
 		nlm_get_host(host);
 		__module_get(THIS_MODULE);
-		if (kernel_thread(reclaimer, host, CLONE_KERNEL))
+		if (kernel_thread(reclaimer, host, CLONE_KERNEL) < 0)
 			module_put(THIS_MODULE);
 	}
 }

                 reply	other threads:[~2003-11-17  9:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031117094026.GA12562@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).