From: Borislav Petkov <bp@alien8.de>
To: David Airlie <airlied@linux.ie>
Cc: Ben Hutchings <ben@decadent.org.uk>,
Eric Anholt <eric@anholt.net>,
Jordan Crouse <jcrouse@codeaurora.org>,
Matthew Garrett <mjg@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] i915, drm: Fix build dependency on VGA_ARB
Date: Thu, 26 Aug 2010 16:59:18 +0200 [thread overview]
Message-ID: <20100826145917.GA3267@a1.tnic> (raw)
I get:
LD init/built-in.o
LD .tmp_vmlinux1
drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa993f): undefined reference to `vga_get'
drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa9963): undefined reference to `vga_put'
make: *** [.tmp_vmlinux1] Error 1
since CONFIG_AGB_ARB is not being selected. Make I915 driver select it
as the numerous other things it selects.
Signed-off-by: Borislav Petkov <bp@alien8.de>
---
This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make
oldconfig' on an Acer Aspire One netbook.
drivers/gpu/drm/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 4cab0c6..43590ab 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -97,6 +97,7 @@ config DRM_I830
config DRM_I915
tristate "i915 driver"
depends on AGP_INTEL
+ select VGA_ARB
select SHMEM
select DRM_KMS_HELPER
select FB_CFB_FILLRECT
--
1.7.1
--
Regards/Gruss,
Boris.
reply other threads:[~2010-08-26 14:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826145917.GA3267@a1.tnic \
--to=bp@alien8.de \
--cc=airlied@linux.ie \
--cc=ben@decadent.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=jcrouse@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).