From: Alexander Viro <viro@math.psu.edu>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org, Alois Treindl <alois@astro.ch>,
"'Bryce'" <bryce@redhat.com>
Subject: [PATCH] Re: Oops with kernel 2.4.5 on heavy disk traffic
Date: Sun, 10 Jun 2001 11:36:35 -0400 (EDT) [thread overview]
Message-ID: <Pine.GSO.4.21.0106101122570.22838-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <Pine.HPX.4.21.0106101259250.9434-100000@as73.astro.ch>
Please, apply. What's happing here is simple - we set i_ino by
PID and get something out of range of per-process inode. Confusion
follows... Fix: move initializing ->u.proc_i.task past the check.
Then proc_delete_inode() will be happy with it.
Alois, Bryce - that ought to fix the oopsen you see.
--- linux/fs/proc/base.c.old Sun Jun 10 11:15:55 2001
+++ linux/fs/proc/base.c Sun Jun 10 11:21:51 2001
@@ -635,15 +635,14 @@
inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
inode->i_ino = fake_ino(task->pid, ino);
- inode->u.proc_i.file = NULL;
+ if (!task->pid)
+ goto out_unlock;
+
/*
* grab the reference to task.
*/
- inode->u.proc_i.task = task;
get_task_struct(task);
- if (!task->pid)
- goto out_unlock;
-
+ inode->u.proc_i.task = task;
inode->i_uid = 0;
inode->i_gid = 0;
if (ino == PROC_PID_INO || task->dumpable) {
next prev parent reply other threads:[~2001-06-10 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-10 11:09 Oops with kernel 2.4.5 on heavy disk traffic Alois Treindl
2001-06-10 15:36 ` Alexander Viro [this message]
2001-06-10 16:02 ` [PATCH] " Alois Treindl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0106101122570.22838-100000@weyl.math.psu.edu \
--to=viro@math.psu.edu \
--cc=alois@astro.ch \
--cc=bryce@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).