From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] firewire: nosy: char device is not seekable
Date: Wed, 13 Oct 2010 14:25:44 +0200 (CEST) [thread overview]
Message-ID: <tkrat.42de7ec9907e63aa@s5r6.in-berlin.de> (raw)
Amend .open handler accordingly and add .llseek = no_llseek handler.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Arnd, is your mega-patch which adds legions of .llseek handlers done and
to be merged soon as-is, or do you regenerate it regularly? (linux-next
commit 9711569d "llseek: automatically add .llseek fop")
drivers/firewire/nosy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: b/drivers/firewire/nosy.c
===================================================================
--- a/drivers/firewire/nosy.c
+++ b/drivers/firewire/nosy.c
@@ -302,7 +302,7 @@ nosy_open(struct inode *inode, struct fi
file->private_data = client;
- return 0;
+ return nonseekable_open(inode, file);
fail:
kfree(client);
lynx_put(lynx);
@@ -400,6 +400,7 @@ nosy_ioctl(struct file *file, unsigned i
static const struct file_operations nosy_ops = {
.owner = THIS_MODULE,
+ .llseek = no_llseek,
.read = nosy_read,
.unlocked_ioctl = nosy_ioctl,
.poll = nosy_poll,
--
Stefan Richter
-=====-==-=- =-=- -==-=
http://arcgraph.de/sr/
next reply other threads:[~2010-10-13 12:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 12:25 Stefan Richter [this message]
2010-10-13 12:31 ` [PATCH] firewire: nosy: char device is not seekable Stefan Richter
2010-10-13 13:54 ` Arnd Bergmann
2010-10-22 23:08 ` [PATCH update] " Stefan Richter
2010-10-23 8:57 ` Arnd Bergmann
2010-10-23 11:47 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.42de7ec9907e63aa@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).