[63/66] execve: make responsive to SIGKILL with large arguments
diff mbox series

Message ID 20101022183601.817868003@clark.site
State New, archived
Headers show
  • review
Related show

Commit Message

Greg KH Oct. 22, 2010, 6:35 p.m. UTC
2.6.32-stable review patch.  If anyone has any objections, please let us know.


From: Roland McGrath <roland@redhat.com>

commit 9aea5a65aa7a1af9a4236dfaeb0088f1624f9919 upstream.

An execve with a very large total of argument/environment strings
can take a really long time in the execve system call.  It runs
uninterruptibly to count and copy all the strings.  This change
makes it abort the exec quickly if sent a SIGKILL.

Note that this is the conservative change, to interrupt only for
SIGKILL, by using fatal_signal_pending().  It would be perfectly
correct semantics to let any signal interrupt the string-copying in
execve, i.e. use signal_pending() instead of fatal_signal_pending().
We'll save that change for later, since it could have user-visible
consequences, such as having a timer set too quickly make it so that
an execve can never complete, though it always happened to work before.

Signed-off-by: Roland McGrath <roland@redhat.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Chuck Ebbert <cebbert@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

 fs/exec.c |    7 +++++++
 1 file changed, 7 insertions(+)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

diff mbox series

--- a/fs/exec.c
+++ b/fs/exec.c
@@ -376,6 +376,9 @@  static int count(char __user * __user *
 			if (i++ >= max)
 				return -E2BIG;
+			if (fatal_signal_pending(current))
+				return -ERESTARTNOHAND;
@@ -419,6 +422,10 @@  static int copy_strings(int argc, char _
 		while (len > 0) {
 			int offset, bytes_to_copy;
+			if (fatal_signal_pending(current)) {
+				goto out;
+			}
 			offset = pos % PAGE_SIZE;