linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: linux-kernel@vger.kernel.org
Subject: [patch] 2.6.5-rc2 __WAITQUEUE_INITIALIZER
Date: Mon, 29 Mar 2004 15:49:13 +1000	[thread overview]
Message-ID: <5648.1080539353@kao2.melbourne.sgi.com> (raw)

When struct __wait_queue is on stack or you reuse an existing
waitqueue, you get garbage in the flags.

Index: 5-rc2.1/include/linux/wait.h
--- 5-rc2.1/include/linux/wait.h Thu, 18 Dec 2003 16:46:13 +1100 kaos (linux-2.6/m/c/34_wait.h 1.1 644)
+++ 5-rc2.1(w)/include/linux/wait.h Mon, 29 Mar 2004 15:36:39 +1000 kaos (linux-2.6/m/c/34_wait.h 1.1 644)
@@ -40,6 +40,7 @@ typedef struct __wait_queue_head wait_qu
  */
 
 #define __WAITQUEUE_INITIALIZER(name, tsk) {				\
+	.flags		= 0,						\
 	.task		= tsk,						\
 	.func		= default_wake_function,			\
 	.task_list	= { NULL, NULL } }


             reply	other threads:[~2004-03-29  5:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-29  5:49 Keith Owens [this message]
2004-03-29  6:53 ` [patch] 2.6.5-rc2 __WAITQUEUE_INITIALIZER Andrew Morton
2004-03-29  8:09   ` Keith Owens
2004-04-02 13:17   ` Tomas Szepe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5648.1080539353@kao2.melbourne.sgi.com \
    --to=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).