dmaengine i.MX SDMA: Fix firmware loading
diff mbox series

Message ID 1294827494-15092-2-git-send-email-s.hauer@pengutronix.de
State New, archived
Headers show
Series
  • dmaengine i.MX SDMA: Fix firmware loading
Related show

Commit Message

Sascha Hauer Jan. 12, 2011, 10:18 a.m. UTC
When loading the microcode to the SDMA engine we have to use
the ram_code_start_addr found in the firmware image. The copy
in the sdma engine is not initialized correctly. This is broken
since:
5b28aa3 dmaengine i.MX SDMA: Allow to run without firmware

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/dma/imx-sdma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Dan Williams Jan. 15, 2011, 12:23 a.m. UTC | #1
On Wed, Jan 12, 2011 at 2:18 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> When loading the microcode to the SDMA engine we have to use
> the ram_code_start_addr found in the firmware image. The copy
> in the sdma engine is not initialized correctly. This is broken
> since:
> 5b28aa3 dmaengine i.MX SDMA: Allow to run without firmware
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---

I'll apply this to my 'fixes' branch once I rebase on top of rc1.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index d5a5d4d..75df8b9 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1135,7 +1135,7 @@  static int __init sdma_get_firmware(struct sdma_engine *sdma,
 	/* download the RAM image for SDMA */
 	sdma_load_script(sdma, ram_code,
 			header->ram_code_size,
-			sdma->script_addrs->ram_code_start_addr);
+			addr->ram_code_start_addr);
 	clk_disable(sdma->clk);
 
 	sdma_add_scripts(sdma, addr);