From: Herbert Xu <herbert@gondor.apana.org.au>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: [PATCH] Call might_sleep in tasklet_kill
Date: Sat, 8 May 2004 15:50:00 +1000 [thread overview]
Message-ID: <20040508055000.GA31358@gondor.apana.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
Hi:
The following patch calls might_sleep in tasklet_kill. This would've
helped in tracking down http://bugs.debian.org/234365 where someone
called tasklet_kill with IRQs disabled.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 575 bytes --]
Index: kernel/softirq.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/kernel/softirq.c,v
retrieving revision 1.1.1.12
diff -u -r1.1.1.12 softirq.c
--- a/kernel/softirq.c 5 Apr 2004 09:49:43 -0000 1.1.1.12
+++ b/kernel/softirq.c 8 May 2004 05:48:50 -0000
@@ -286,8 +286,7 @@
void tasklet_kill(struct tasklet_struct *t)
{
- if (in_interrupt())
- printk("Attempt to kill tasklet from interrupt\n");
+ might_sleep();
while (test_and_set_bit(TASKLET_STATE_SCHED, &t->state)) {
do
reply other threads:[~2004-05-08 5:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040508055000.GA31358@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).