[MTD] Tone down overly noisy JEDEC probing
diff mbox series

Message ID 20040607104318.GA18030@gondor.apana.org.au
State New, archived
Headers show
Series
  • [MTD] Tone down overly noisy JEDEC probing
Related show

Commit Message

Herbert Xu June 7, 2004, 10:43 a.m. UTC
Hi:

If you have a look at

http://bugs.debian.org/cgi-bin/bugreport.cgi/dmesg.dump?bug=250093&msg=3&att=2

you'll see that JEDEC probing is way too noisy.  Since that module
is now being loaded automatically by hotplug, it should probably
be toned down.

The following patch turns the printk's into DEBUG calls.  Please let
me know if you've got any problems with that.

Thanks,

Patch
diff mbox series

===== drivers/mtd/chips/gen_probe.c 1.4 vs edited =====
--- 1.4/drivers/mtd/chips/gen_probe.c	2003-09-30 10:25:16 +10:00
+++ edited/drivers/mtd/chips/gen_probe.c	2004-06-07 20:30:46 +10:00
@@ -65,8 +65,9 @@ 
 	   interleave and device type, etc. */
 	if (!genprobe_new_chip(map, cp, &cfi)) {
 		/* The probe didn't like it */
-		printk(KERN_WARNING "%s: Found no %s device at location zero\n",
-		       cp->name, map->name);
+		DEBUG(MTD_DEBUG_LEVEL3,
+		      "MTD %s(): %s: Found no %s device at location zero\n",
+		      __func__, cp->name, map->name);
 		return NULL;
 	}		
 
===== drivers/mtd/chips/jedec_probe.c 1.11 vs edited =====
--- 1.11/drivers/mtd/chips/jedec_probe.c	2004-06-05 18:14:08 +10:00
+++ edited/drivers/mtd/chips/jedec_probe.c	2004-06-07 20:42:08 +10:00
@@ -1668,8 +1668,10 @@ 
 		
 		cfi->mfr = jedec_read_mfr(map, base, cfi);
 		cfi->id = jedec_read_id(map, base, cfi);
-		printk(KERN_INFO "Search for id:(%02x %02x) interleave(%d) type(%d)\n", 
-			cfi->mfr, cfi->id, cfi->interleave, cfi->device_type);
+		DEBUG(MTD_DEBUG_LEVEL3,
+		      "MTD %s(): Search for id:(%02x %02x) interleave(%d) type(%d)\n", 
+		      __func__, cfi->mfr, cfi->id, cfi->interleave,
+		      cfi->device_type);
 		for (i=0; i<sizeof(jedec_table)/sizeof(jedec_table[0]); i++) {
 			if ( jedec_match( base, map, cfi, &jedec_table[i] ) ) {
 				DEBUG( MTD_DEBUG_LEVEL3,