From: Herbert Xu <herbert@gondor.apana.org.au>
To: David Woodhouse <dwmw2@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [MTD] Tone down overly noisy JEDEC probing
Date: Mon, 7 Jun 2004 20:43:18 +1000 [thread overview]
Message-ID: <20040607104318.GA18030@gondor.apana.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
Hi:
If you have a look at
http://bugs.debian.org/cgi-bin/bugreport.cgi/dmesg.dump?bug=250093&msg=3&att=2
you'll see that JEDEC probing is way too noisy. Since that module
is now being loaded automatically by hotplug, it should probably
be toned down.
The following patch turns the printk's into DEBUG calls. Please let
me know if you've got any problems with that.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 1371 bytes --]
===== drivers/mtd/chips/gen_probe.c 1.4 vs edited =====
--- 1.4/drivers/mtd/chips/gen_probe.c 2003-09-30 10:25:16 +10:00
+++ edited/drivers/mtd/chips/gen_probe.c 2004-06-07 20:30:46 +10:00
@@ -65,8 +65,9 @@
interleave and device type, etc. */
if (!genprobe_new_chip(map, cp, &cfi)) {
/* The probe didn't like it */
- printk(KERN_WARNING "%s: Found no %s device at location zero\n",
- cp->name, map->name);
+ DEBUG(MTD_DEBUG_LEVEL3,
+ "MTD %s(): %s: Found no %s device at location zero\n",
+ __func__, cp->name, map->name);
return NULL;
}
===== drivers/mtd/chips/jedec_probe.c 1.11 vs edited =====
--- 1.11/drivers/mtd/chips/jedec_probe.c 2004-06-05 18:14:08 +10:00
+++ edited/drivers/mtd/chips/jedec_probe.c 2004-06-07 20:42:08 +10:00
@@ -1668,8 +1668,10 @@
cfi->mfr = jedec_read_mfr(map, base, cfi);
cfi->id = jedec_read_id(map, base, cfi);
- printk(KERN_INFO "Search for id:(%02x %02x) interleave(%d) type(%d)\n",
- cfi->mfr, cfi->id, cfi->interleave, cfi->device_type);
+ DEBUG(MTD_DEBUG_LEVEL3,
+ "MTD %s(): Search for id:(%02x %02x) interleave(%d) type(%d)\n",
+ __func__, cfi->mfr, cfi->id, cfi->interleave,
+ cfi->device_type);
for (i=0; i<sizeof(jedec_table)/sizeof(jedec_table[0]); i++) {
if ( jedec_match( base, map, cfi, &jedec_table[i] ) ) {
DEBUG( MTD_DEBUG_LEVEL3,
reply other threads:[~2004-06-07 10:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040607104318.GA18030@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).