From: Jassi Brar <jassisinghbrar@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: ti@lists.linaro.org, linux-omap@vger.kernel.org, lrg@ti.com,
broonie@opensource.wolfsonmicro.com, sameo@linux.intel.com,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: [PATCH] regulator: twl: Add 'fixed' set_voltage callback
Date: Fri, 24 Jun 2011 02:16:54 +0530 [thread overview]
Message-ID: <1308862014-11212-1-git-send-email-jaswinder.singh@linaro.org> (raw)
Define dummy set_voltage callback for fixed lines,
without which voltage constraints fail to apply.
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
drivers/regulator/twl-regulator.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 87fe0f7..8223e49 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -591,10 +591,18 @@ static int twlfixed_get_voltage(struct regulator_dev *rdev)
return info->min_mV * 1000;
}
+static int twlfixed_set_voltage(struct regulator_dev *rdev,
+ int min_uV, int max_uV, unsigned *selector)
+{
+ *selector = min_uV / 1000;
+ return 0;
+}
+
static struct regulator_ops twl4030fixed_ops = {
.list_voltage = twlfixed_list_voltage,
.get_voltage = twlfixed_get_voltage,
+ .set_voltage = twlfixed_set_voltage,
.enable = twl4030reg_enable,
.disable = twl4030reg_disable,
@@ -609,6 +617,7 @@ static struct regulator_ops twl6030fixed_ops = {
.list_voltage = twlfixed_list_voltage,
.get_voltage = twlfixed_get_voltage,
+ .set_voltage = twlfixed_set_voltage,
.enable = twl6030reg_enable,
.disable = twl6030reg_disable,
--
1.7.4.1
next reply other threads:[~2011-06-23 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 20:46 Jassi Brar [this message]
2011-06-24 11:19 ` [PATCH] regulator: twl: Add 'fixed' set_voltage callback Mark Brown
2011-06-24 13:06 ` Jaswinder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308862014-11212-1-git-send-email-jaswinder.singh@linaro.org \
--to=jassisinghbrar@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=ti@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).