From: Francois Romieu <romieu@cogenit.fr>
To: Andres Salomon <dilinger@mp3revolution.net>
Cc: linux-kernel@vger.kernel.org, alan@redhat.com
Subject: [patch] Re: OOPS in 2.4.6's drivers/scsi/in2000.c
Date: Thu, 9 Aug 2001 13:16:22 +0200 [thread overview]
Message-ID: <20010809131622.A11250@se1.cogenit.fr> (raw)
In-Reply-To: <20010806000600.A2269@mp3revolution.net>
In-Reply-To: <20010806000600.A2269@mp3revolution.net>; from dilinger@mp3revolution.net on Mon, Aug 06, 2001 at 12:06:00AM -0400
The driver does readX instead of isa_readX on isa addresses.
Alan, please apply and forward.
--- linux-2.4.7-ac9.orig/drivers/scsi/in2000.c Thu Aug 2 09:50:33 2001
+++ linux-2.4.7-ac9/drivers/scsi/in2000.c Thu Aug 9 13:06:25 2001
@@ -1909,10 +1909,10 @@ char *cp;
* special macros declared in 'asm/io.h'. We use readb() and readl()
* when reading from the card's BIOS area in in2000_detect().
*/
-static const unsigned int *bios_tab[] in2000__INITDATA = {
- (unsigned int *)0xc8000,
- (unsigned int *)0xd0000,
- (unsigned int *)0xd8000,
+static u32 bios_tab[] in2000__INITDATA = {
+ 0xc8000,
+ 0xd0000,
+ 0xd8000,
0
};
@@ -1973,13 +1973,13 @@ char buf[32];
* for the obvious ID strings. We look for the 2 most common ones and
* hope that they cover all the cases...
*/
- else if (readl(bios_tab[bios]+0x04) == 0x41564f4e ||
- readl(bios_tab[bios]+0x0c) == 0x61776c41) {
+ else if (isa_readl(bios_tab[bios]+0x10) == 0x41564f4e ||
+ isa_readl(bios_tab[bios]+0x30) == 0x61776c41) {
printk("Found IN2000 BIOS at 0x%x ",(unsigned int)bios_tab[bios]);
/* Read the switch image that's mapped into EPROM space */
- switches = ~((readb(bios_tab[bios]+0x08) & 0xff));
+ switches = ~((isa_readb(bios_tab[bios]+0x20) & 0xff));
/* Find out where the IO space is */
@@ -2073,7 +2073,7 @@ char buf[32];
/* Older BIOS's had a 'sync on/off' switch - use its setting */
- if (readl(bios_tab[bios]+0x04) == 0x41564f4e && (switches & SW_SYNC_DOS5))
+ if (isa_readl(bios_tab[bios]+0x10) == 0x41564f4e && (switches & SW_SYNC_DOS5))
hostdata->sync_off = 0x00; /* sync defaults to on */
else
hostdata->sync_off = 0xff; /* sync defaults to off */
--
Ueimor
prev parent reply other threads:[~2001-08-09 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-06 4:06 OOPS in 2.4.6's drivers/scsi/in2000.c Andres Salomon
2001-08-09 11:16 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010809131622.A11250@se1.cogenit.fr \
--to=romieu@cogenit.fr \
--cc=alan@redhat.com \
--cc=dilinger@mp3revolution.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).