[I4L] Fix IRQ-sharing lockup in nj_s
diff mbox series

Message ID 20040727082241.GA15624@gondor.apana.org.au
State New, archived
Headers show
Series
  • [I4L] Fix IRQ-sharing lockup in nj_s
Related show

Commit Message

Herbert Xu July 27, 2004, 8:22 a.m. UTC
Hi:

This is a backport of a fix that's already in 2.6.  The problem is that
nj_s is enabling interrupts before the handler is even installed.  This
patch delays the call until after the handler has been registered.

Cheers,

Comments

Karsten Keil July 27, 2004, 10:19 a.m. UTC | #1
Yes, correct.

On Tue, Jul 27, 2004 at 06:22:41PM +1000, Herbert Xu wrote:
> Hi:
> 
> This is a backport of a fix that's already in 2.6.  The problem is that
> nj_s is enabling interrupts before the handler is even installed.  This
> patch delays the call until after the handler has been registered.
> 
> Cheers,
> -- 
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


Signed-off-by: Karsten Keil <kkeil@suse.de>

===== drivers/isdn/hisax/nj_s.c 1.7 vs edited =====
--- 1.7/drivers/isdn/hisax/nj_s.c	2002-04-01 11:02:11 +10:00
+++ edited/drivers/isdn/hisax/nj_s.c	2004-07-27 18:19:41 +10:00
@@ -130,6 +130,7 @@
 			release_io_netjet(cs);
 			return(0);
 		case CARD_INIT:
+			reset_netjet_s(cs);
 			inittiger(cs);
 			clear_pending_isac_ints(cs);
 			initisac(cs);
@@ -262,7 +263,6 @@
 	} else {
 		request_region(cs->hw.njet.base, bytecnt, "netjet-s isdn");
 	}
-	reset_netjet_s(cs);
 	cs->readisac  = &NETjet_ReadIC;
 	cs->writeisac = &NETjet_WriteIC;
 	cs->readisacfifo  = &NETjet_ReadICfifo;
Marcelo Tosatti July 27, 2004, 9:56 p.m. UTC | #2
Applied, thanks Herbert and Karsten.

Just please stop using my old email address :) 

On Tue, Jul 27, 2004 at 12:19:27PM +0200, Karsten Keil wrote:
> Yes, correct.
> 
> On Tue, Jul 27, 2004 at 06:22:41PM +1000, Herbert Xu wrote:
> > Hi:
> > 
> > This is a backport of a fix that's already in 2.6.  The problem is that
> > nj_s is enabling interrupts before the handler is even installed.  This
> > patch delays the call until after the handler has been registered.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

===== drivers/isdn/hisax/nj_s.c 1.7 vs edited =====
--- 1.7/drivers/isdn/hisax/nj_s.c	2002-04-01 11:02:11 +10:00
+++ edited/drivers/isdn/hisax/nj_s.c	2004-07-27 18:19:41 +10:00
@@ -130,6 +130,7 @@ 
 			release_io_netjet(cs);
 			return(0);
 		case CARD_INIT:
+			reset_netjet_s(cs);
 			inittiger(cs);
 			clear_pending_isac_ints(cs);
 			initisac(cs);
@@ -262,7 +263,6 @@ 
 	} else {
 		request_region(cs->hw.njet.base, bytecnt, "netjet-s isdn");
 	}
-	reset_netjet_s(cs);
 	cs->readisac  = &NETjet_ReadIC;
 	cs->writeisac = &NETjet_WriteIC;
 	cs->readisacfifo  = &NETjet_ReadICfifo;