From: Herbert Xu <herbert@gondor.apana.org.au>
To: akpm@osdl.org, benh@kernel.crashing.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: mdz@canonical.com
Subject: [PATCH] Use msleep_interruptible for therm_adt7467.c kernel thread
Date: Mon, 27 Sep 2004 20:25:52 +1000 [thread overview]
Message-ID: <20040927102552.GA19183@gondor.apana.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
Hi:
Using msleep() in a kernel thread causes it to show up in the D state
and contribute towards the system load average. The following patch
converts it to msleep_interruptible().
The continue is just paranoia in case something relies on the sleep
to take 2 seconds or more.
This bug was reported at
https://bugzilla.no-name-yet.com/show_bug.cgi?id=1804
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 366 bytes --]
===== drivers/macintosh/therm_adt746x.c 1.5 vs edited =====
--- 1.5/drivers/macintosh/therm_adt746x.c 2004-09-23 06:31:14 +10:00
+++ edited/drivers/macintosh/therm_adt746x.c 2004-09-27 20:24:58 +10:00
@@ -246,7 +246,8 @@
while(monitor_running)
{
- msleep(2000);
+ if (msleep_interruptible(2000))
+ continue;
/* Check status */
/* local : chip */
next reply other threads:[~2004-09-27 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 10:25 Herbert Xu [this message]
2004-09-27 12:51 ` [PATCH] Use msleep_interruptible for therm_adt7467.c kernel thread Alan Cox
2004-09-29 1:58 ` Herbert Xu
2004-09-29 1:24 ` Alan Cox
2004-09-29 4:12 ` Benjamin Herrenschmidt
2004-09-29 4:13 ` Benjamin Herrenschmidt
2004-09-30 4:40 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927102552.GA19183@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdz@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).