From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: netdev@oss.sgi.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH RESEND] 2.[46]: Set ARP hw type correctly for BOOTP over FDDI
Date: Mon, 4 Oct 2004 23:56:59 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.58L.0410040310550.22545@blysk.ds.pg.gda.pl> (raw)
Hello,
Using the Ethernet ARP hw type for FDDI networks is mandated by RFC 1390
(STD 36) and that code is already used by Linux elsewhere, but not for
BOOTP requests sent for IPv4 autoconfiguration. Here is a patch for both
2.4 and 2.6 that fixes the problem for me. Please apply.
Applies both to 2.4.27 and to 2.6.8.1.
Maciej
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
patch-ipconfig-fddi-0
diff -up --recursive --new-file linux.macro/net/ipv4/ipconfig.c linux/net/ipv4/ipconfig.c
--- linux.macro/net/ipv4/ipconfig.c 2003-11-17 04:00:34.000000000 +0000
+++ linux/net/ipv4/ipconfig.c 2004-08-12 00:03:32.000000000 +0000
@@ -689,6 +689,8 @@ static void __init ic_bootp_send_if(stru
b->htype = dev->type;
else if (dev->type == ARPHRD_IEEE802_TR) /* fix for token ring */
b->htype = ARPHRD_IEEE802;
+ else if (dev->type == ARPHRD_FDDI)
+ b->htype = ARPHRD_ETHER;
else {
printk("Unknown ARP type 0x%04x for device %s\n", dev->type, dev->name);
b->htype = dev->type; /* can cause undefined behavior */
next reply other threads:[~2004-10-04 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 22:56 Maciej W. Rozycki [this message]
2004-10-05 19:53 ` [PATCH RESEND] 2.[46]: Set ARP hw type correctly for BOOTP over FDDI David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58L.0410040310550.22545@blysk.ds.pg.gda.pl \
--to=macro@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).