[HID] Fix hiddev devfs oops

From: Herbert Xu <herbert@gondor.apana.org.au>
To: Vojtech Pavlik <vojtech@suse.cz>, linux-usb-devel@lists.sourceforge.net
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [HID] Fix hiddev devfs oops
Date: Tue, 5 Oct 2004 22:49:14 +1000	[thread overview]
Message-ID: <20041005124914.GA1009@gondor.apana.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

Hi:

There is a long-standing devfs_unregister oops in hid/hiddev.  It's
caused by hid calling hiddev_exit before unregistering itself which
in turn calls hiddev_disconnect.

hiddev_exit removes the directory which contains the hiddev devices.
Therefore it needs to be called after the hiddev devices have been
disconnected.

This patch fixes that.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Marcelo, the same fix is needed in 2.4 as well.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p-2.6 --]
[-- Type: text/plain, Size: 344 bytes --]

===== drivers/usb/input/hid-core.c 1.94 vs edited =====

--- 1.94/drivers/usb/input/hid-core.c	2004-08-25 22:01:29 +10:00
+++ edited/drivers/usb/input/hid-core.c	2004-10-05 22:44:03 +10:00
@@ -1859,8 +1859,8 @@
 
 static void __exit hid_exit(void)
 {
-	hiddev_exit();
 	usb_deregister(&hid_driver);
+	hiddev_exit();
 }
 
 module_init(hid_init);

[-- Attachment #3: p-2.4 --]
[-- Type: text/plain, Size: 326 bytes --]

===== drivers/usb/hid-core.c 1.30 vs edited =====
--- 1.30/drivers/usb/hid-core.c	2004-08-08 18:59:53 +10:00
+++ edited/drivers/usb/hid-core.c	2004-10-05 22:33:52 +10:00
@@ -1459,8 +1459,8 @@
 
 static void __exit hid_exit(void)
 {
-	hiddev_exit();
 	usb_deregister(&hid_driver);
+	hiddev_exit();
 }
 
 module_init(hid_init);
