From: shaohua li <shaoh.li@gmail.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [patch]pc110pad.c small fix
Date: Fri, 8 Oct 2004 16:05:21 +0800 [thread overview]
Message-ID: <288dbef704100801055d151079@mail.gmail.com> (raw)
Hi,
'request_region' returns NULL if failed. The driver does the contrary.
Thanks,
Shaohua
Signed-off-by: Li Shaohua <shaoh.li@gmail.com>
===== drivers/input/mouse/pc110pad.c 1.9 vs edited =====
--- 1.9/drivers/input/mouse/pc110pad.c 2004-07-27 05:27:05 +08:00
+++ edited/drivers/input/mouse/pc110pad.c 2004-08-04 16:56:17 +08:00
@@ -109,7 +109,7 @@ static int pc110pad_open(struct input_de
static int __init pc110pad_init(void)
{
- if (request_region(pc110pad_io, 4, "pc110pad"))
+ if (!request_region(pc110pad_io, 4, "pc110pad"))
{
printk(KERN_ERR "pc110pad: I/O area %#x-%#x in use.\n",
pc110pad_io, pc110pad_io + 4);
return -EBUSY;
reply other threads:[~2004-10-08 8:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288dbef704100801055d151079@mail.gmail.com \
--to=shaoh.li@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).