From: Jason Wang <jasowang@redhat.com>
To: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
mst@redhat.com
Subject: [PATCH] virtio-spec: clarify ro/rw bits and updating rule of virtio-net status field
Date: Tue, 20 Mar 2012 14:20:21 +0800 [thread overview]
Message-ID: <20120320062020.12815.61342.stgit@jason-ThinkPad-T400> (raw)
This patch clarifies VIRTIO_NET_S_LINK_UP as a read-only bit and
VIRTIO_NET_S_ANNOUNCE as a read-writable bit. Also introduce the write 1 to
clear semantics for all read-writable bits of config status field. This could
help to reduce the config status field updating race between host and guest and
also simplify the implementation.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
virtio-0.9.4.lyx | 23 +++++++++++++++++++++--
1 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/virtio-0.9.4.lyx b/virtio-0.9.4.lyx
index 6c7bab1..614ab55 100644
--- a/virtio-0.9.4.lyx
+++ b/virtio-0.9.4.lyx
@@ -58,6 +58,7 @@
\html_be_strict false
\author -608949062 "Rusty Russell,,,"
\author 1531152142 "pbonzini"
+\author 2090695081 "jason"
\end_header
\begin_body
@@ -4013,7 +4014,21 @@ layout Two configuration fields are currently defined.
The mac address field always exists (though is only valid if VIRTIO_NET_F_MAC
is set), and the status field only exists if VIRTIO_NET_F_STATUS is set.
Two bits are currently defined for the status field: VIRTIO_NET_S_LINK_UP
- and VIRTIO_NET_S_ANNOUNCE.
+
+\change_inserted 2090695081 1332220873
+(read-only)
+\change_unchanged
+and VIRTIO_NET_S_ANNOUNCE
+\change_inserted 2090695081 1332220883
+ (read-writable)
+\change_unchanged
+.
+
+\change_inserted 2090695081 1332220901
+ Writing 1 to any read-writable bit of status filed would cause the bit
+ to be cleared.
+
+\change_unchanged
\begin_inset listings
inline false
@@ -4915,7 +4930,11 @@ Processing this notification involves:
\end_layout
\begin_layout Enumerate
-Clearing VIRTIO_NET_S_ANNOUNCE bit in the status field.
+Clearing VIRTIO_NET_S_ANNOUNCE bit in the status field
+\change_inserted 2090695081 1332220849
+ (by writing 1 to VIRTIO_NET_S_ANNOUNCE bit)
+\change_unchanged
+.
\end_layout
\begin_layout Enumerate
next reply other threads:[~2012-03-20 6:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 6:20 Jason Wang [this message]
2012-03-20 11:05 ` [PATCH] virtio-spec: clarify ro/rw bits and updating rule of virtio-net status field Rusty Russell
2012-03-20 22:48 ` Michael S. Tsirkin
2012-03-20 23:40 ` Rusty Russell
2012-03-21 6:37 ` Michael S. Tsirkin
2012-03-22 4:30 ` Rusty Russell
2012-03-23 2:57 ` [Qemu-devel] " Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320062020.12815.61342.stgit@jason-ThinkPad-T400 \
--to=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).