From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org
Subject: On patch "device.h: audit and cleanup users in main include dir"
Date: Sat, 24 Mar 2012 21:21:25 +0100 [thread overview]
Message-ID: <20120324212125.460c89d3@stein> (raw)
Hi Paul,
commit 313162d0b83836e2f57e51b9b8650fb4b9c396ea is not 100.00% correct.
--- a/include/linux/firewire.h
+++ b/include/linux/firewire.h
@@ -2,7 +2,6 @@
#define _LINUX_FIREWIRE_H
#include <linux/completion.h>
-#include <linux/device.h>
#include <linux/dma-mapping.h>
#include <linux/kernel.h>
#include <linux/kref.h>
@@ -68,6 +67,8 @@
#define CSR_MODEL 0x17
#define CSR_DIRECTORY_ID 0x20
+struct device;
+
struct fw_csr_iterator {
const u32 *p;
const u32 *end;
But struct fw_device and struct fw_unit, defined in include/firewire.h,
incorporate struct device.
Furthermore, the inline function definitions
fw_device,
fw_unit,
fw_unit_get,
fw_unit_put,
fw_parent_device
all require definitions from linux/device.h.
--
Stefan Richter
-=====-===-- --== ==---
http://arcgraph.de/sr/
next reply other threads:[~2012-03-24 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 20:21 Stefan Richter [this message]
2012-03-25 1:05 ` On patch "device.h: audit and cleanup users in main include dir" Paul Gortmaker
2012-03-25 10:37 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324212125.460c89d3@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).