From: Paul Mackerras <paulus@samba.org>
To: akpm@osdl.org
Cc: Linas Vepstas <linas@austin.ibm.com>,
anton@samba.org, linux-kernel@vger.kernel.org
Subject: [PATCH] PPC64: crash during firmware flash update
Date: Sat, 23 Oct 2004 17:52:22 +1000 [thread overview]
Message-ID: <16762.3510.255380.586200@cargo.ozlabs.ibm.com> (raw)
This patch is from Linas Vepstas <linas@austin.ibm.com>.
Race conditions during system shutdown after a firmware
flash can sometimes lead to an invalid pointer deref (deref
to freed memory). This patch fixes this. In addition, it makes
sure that the proc entries created by the firmware flash module
are removed when the module is unloaded.
Signed-off-by: Linas Vepstas <linas@linas.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
diff -urN linux-2.5/arch/ppc64/kernel/rtas_flash.c test/arch/ppc64/kernel/rtas_flash.c
--- linux-2.5/arch/ppc64/kernel/rtas_flash.c 2004-06-25 07:03:03.000000000 +1000
+++ test/arch/ppc64/kernel/rtas_flash.c 2004-10-23 17:38:33.445013280 +1000
@@ -562,6 +562,7 @@
validate_flash(args_buf);
}
+ /* The matching atomic_inc was in rtas_excl_open() */
atomic_dec(&dp->count);
return 0;
@@ -572,7 +573,8 @@
if (dp) {
if (dp->data != NULL)
kfree(dp->data);
- remove_proc_entry(dp->name, NULL);
+ dp->owner = NULL;
+ remove_proc_entry(dp->name, dp->parent);
}
}
reply other threads:[~2004-10-23 7:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16762.3510.255380.586200@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).