From: andrew may <acmay@acmay.homeip.net>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ipip.c & ip_gre.c (Add Tunnel return)
Date: Tue, 25 Sep 2001 15:26:28 -0700 [thread overview]
Message-ID: <20010925152628.A8042@ecam.san.rr.com> (raw)
I think the tunnel drivers should return the name of the
device the tunnel add created. Currently the tunnel_lookup
functions copy the name into the stack var in the ioctl
function but the ioctl copies the parm from the tunnel
device.
--- linux.org/net/ipv4/ip_gre.c Tue Sep 25 02:27:58 2001
+++ linux/net/ipv4/ip_gre.c Tue Sep 25 02:34:03 2001
@@ -284,7 +284,7 @@
}
if (i==100)
goto failed;
- memcpy(parms->name, dev->name, IFNAMSIZ);
+ memcpy(nt->parms.name, dev->name, IFNAMSIZ);
}
if (register_netdevice(dev) < 0)
goto failed;
diff -ur linux.org/net/ipv4/ipip.c linux/net/ipv4/ipip.c
--- linux.org/net/ipv4/ipip.c Tue Sep 25 02:27:52 2001
+++ linux/net/ipv4/ipip.c Tue Sep 25 02:32:59 2001
@@ -255,7 +255,7 @@
}
if (i==100)
goto failed;
- memcpy(parms->name, dev->name, IFNAMSIZ);
+ memcpy(nt->parms.name, dev->name, IFNAMSIZ);
}
if (register_netdevice(dev) < 0)
goto failed;
next reply other threads:[~2001-09-25 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-25 22:26 andrew may [this message]
2001-09-25 22:31 ` [PATCH] ipip.c & ip_gre.c (Add Tunnel return) David S. Miller
2001-09-25 22:36 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010925152628.A8042@ecam.san.rr.com \
--to=acmay@acmay.homeip.net \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).