From: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
To: linux-kernel@vger.kernel.org
Cc: torvalds@transmeta.com
Subject: [PATCH] Linux 0.01 disk lockup
Date: Thu, 27 Sep 2001 15:34:11 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.3.96.1010927150812.28147B-100000@artax.karlin.mff.cuni.cz> (raw)
Hi.
Linux 0.01 has a bug in disk request sorting - when interrupt happens
while sorting is active, the interrupt routine won't clear do_hd - thus
the disk will stay locked up forever.
Function add_request also lacks memory barriers - the compiler could
reorder writes to variable sorting and writes to request queue - producing
race conditions. Because gcc 1.40 does not have __asm__("":::"memory"), I
had to use dummy function call as a memory barrier.
The following patch fixes both issues.
Mikulas
diff -u -r linux-orig/kernel/hd.c linux/kernel/hd.c
--- linux-orig/kernel/hd.c Tue Sep 17 17:05:21 1991
+++ linux/kernel/hd.c Thu Sep 27 15:14:38 2001
@@ -55,9 +55,9 @@
((s1)->head<(s2)->head || (s1)->head==(s2)->head && \
((s1)->sector<(s2)->sector))))
-static struct hd_request * this_request = NULL;
+struct hd_request * this_request = NULL;
-static int sorting=0;
+int sorting=0;
static void do_request(void);
static void reset_controller(void);
@@ -293,8 +293,10 @@
{
int i,r;
- if (sorting)
+ if (sorting) {
+ do_hd=NULL;
return;
+ }
if (!this_request) {
do_hd=NULL;
return;
@@ -319,6 +321,8 @@
panic("unknown hd-command");
}
+void barrier();
+
/*
* add-request adds a request to the linked list.
* It sets the 'sorting'-variable when doing something
@@ -338,6 +342,7 @@
* disabling interrupts.
*/
sorting=1;
+ barrier();
if (!(tmp=this_request))
this_request=req;
else {
@@ -354,15 +359,19 @@
tmp->next=req;
}
}
+ barrier();
sorting=0;
+ barrier();
/*
* NOTE! As a result of sorting, the interrupts may have died down,
* as they aren't redone due to locking with sorting=1. They might
* also never have started, if this is the first request in the queue,
* so we restart them if necessary.
*/
- if (!do_hd)
+ if (!do_hd) {
+ barrier();
do_request();
+ }
}
void rw_abs_hd(int rw,unsigned int nr,unsigned int sec,unsigned int head,
diff -u -r linux-orig/kernel/system_call.s linux/kernel/system_call.s
--- linux-orig/kernel/system_call.s Tue Sep 17 17:50:52 1991
+++ linux/kernel/system_call.s Thu Sep 27 14:59:37 2001
@@ -47,7 +47,7 @@
nr_system_calls = 67
-.globl _system_call,_sys_fork,_timer_interrupt,_hd_interrupt,_sys_execve
+.globl _system_call,_sys_fork,_timer_interrupt,_hd_interrupt,_sys_execve,_barrier
.align 2
bad_sys_call:
@@ -186,6 +186,9 @@
call _copy_process
addl $20,%esp
1: ret
+
+_barrier:
+ ret
_hd_interrupt:
pushl %eax
next reply other threads:[~2001-09-27 13:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-27 13:34 Mikulas Patocka [this message]
2001-09-27 13:47 ` [PATCH] Linux 0.01 disk lockup Arnaldo Carvalho de Melo
2001-09-27 20:02 ` Paul Gortmaker
2001-09-27 21:18 ` Aaron Tiensivu
2001-09-27 15:12 ` Richard Gooch
2001-09-27 15:18 ` Roeland Th. Jansen
2001-09-27 15:20 ` Richard Gooch
2001-09-27 16:07 ` Mikulas Patocka
2001-09-27 15:27 ` Linus Torvalds
2001-09-27 16:08 ` Mikulas Patocka
2001-09-29 21:16 ` [PATCH] Linux 0.01 disk lockup - read the old (1991) archives Rob Landley
2001-09-30 12:29 ` Alan Cox
2001-10-01 14:08 ` Rob Landley
2001-10-01 18:36 ` Virtual terminal support Rok Pergarec
2001-10-01 19:22 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.3.96.1010927150812.28147B-100000@artax.karlin.mff.cuni.cz \
--to=mikulas@artax.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).