linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Cc: linux-kernel@vger.kernel.org, marcelo.tosatti@cyclades.com
Subject: [PATCH] oops on boot when initializing CDROM
Date: Wed, 17 Nov 2004 11:08:48 -0800	[thread overview]
Message-ID: <419BA1C0.3040601@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0411162336510.24144@artax.karlin.mff.cuni.cz>

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Mikulas Patocka wrote:
> When booting kernel 2.4.27 on notebook with cd-rw dvd-ro drive, I get oops
> on cdrom_sysctl_register+2a trying to dereference address 20.
> Call stack: register_cdrom+235
> 
> gcc-3.2.3

Thanks for the .config file.

with: CONFIG_SYSCTL=y, CONFIG_PROC_FS=n

Am I confused here, or is the 2.4 (and 2.6) source code confused?


diffstat:=
  drivers/cdrom/cdrom.c |    2 --
  1 files changed, 2 deletions(-)

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
-- 

[-- Attachment #2: cdrom_sysctl_24.patch --]
[-- Type: text/x-patch, Size: 522 bytes --]

diff -Naurp ./drivers/cdrom/cdrom.c~cdrom_sysctl ./drivers/cdrom/cdrom.c
--- ./drivers/cdrom/cdrom.c~cdrom_sysctl	2003-11-28 10:26:20.000000000 -0800
+++ ./drivers/cdrom/cdrom.c	2004-11-17 10:45:45.666804288 -0800
@@ -2598,9 +2598,7 @@ ctl_table cdrom_cdrom_table[] = {
 
 /* Make sure that /proc/sys/dev is there */
 ctl_table cdrom_root_table[] = {
-#ifdef CONFIG_PROC_FS
 	{CTL_DEV, "dev", NULL, 0, 0555, cdrom_cdrom_table},
-#endif /* CONFIG_PROC_FS */
 	{0}
 	};
 static struct ctl_table_header *cdrom_sysctl_header;

  reply	other threads:[~2004-11-17 19:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-16 22:41 oops on boot when initializing CDROM Mikulas Patocka
2004-11-17 19:08 ` Randy.Dunlap [this message]
2004-11-17 17:19   ` [PATCH] " Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=419BA1C0.3040601@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=mikulas@artax.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).