[1/3] zram/zcache: swtich Kconfig dependency from X86 to ZSMALLOC
diff mbox series

Message ID 1340640878-27536-2-git-send-email-sjenning@linux.vnet.ibm.com
State New, archived
Headers show
Series
  • zsmalloc: remove x86 dependency
Related show

Commit Message

Seth Jennings June 25, 2012, 4:14 p.m. UTC
This patch switches zcache and zram dependency to ZSMALLOC
rather than X86.  There is no net change since ZSMALLOC
depends on X86, however, this prevent further changes to
these files as zsmalloc dependencies change.

Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
---
 drivers/staging/zcache/Kconfig |    5 +----
 drivers/staging/zram/Kconfig   |    5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

Comments

Minchan Kim June 27, 2012, 2:37 a.m. UTC | #1
On 06/26/2012 01:14 AM, Seth Jennings wrote:

> This patch switches zcache and zram dependency to ZSMALLOC
> rather than X86.  There is no net change since ZSMALLOC
> depends on X86, however, this prevent further changes to
> these files as zsmalloc dependencies change.
> 
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>

Reviewed-by: Minchan Kim <minchan@kernel.org>

It could be merged regardless of other patches in this series.
Greg KH June 27, 2012, 2:43 a.m. UTC | #2
On Wed, Jun 27, 2012 at 11:37:25AM +0900, Minchan Kim wrote:
> On 06/26/2012 01:14 AM, Seth Jennings wrote:
> 
> > This patch switches zcache and zram dependency to ZSMALLOC
> > rather than X86.  There is no net change since ZSMALLOC
> > depends on X86, however, this prevent further changes to
> > these files as zsmalloc dependencies change.
> > 
> > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> 
> Reviewed-by: Minchan Kim <minchan@kernel.org>
> 
> It could be merged regardless of other patches in this series.

I already did :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Minchan Kim June 27, 2012, 2:49 a.m. UTC | #3
Hi Greg,

On 06/27/2012 11:43 AM, Greg Kroah-Hartman wrote:

> On Wed, Jun 27, 2012 at 11:37:25AM +0900, Minchan Kim wrote:
>> On 06/26/2012 01:14 AM, Seth Jennings wrote:
>>
>>> This patch switches zcache and zram dependency to ZSMALLOC
>>> rather than X86.  There is no net change since ZSMALLOC
>>> depends on X86, however, this prevent further changes to
>>> these files as zsmalloc dependencies change.
>>>
>>> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>>
>> Reviewed-by: Minchan Kim <minchan@kernel.org>
>>
>> It could be merged regardless of other patches in this series.
> 
> I already did :)


It would have been better if you send merge mail to Ccing people.
Anyway, Thanks!
Greg KH June 27, 2012, 3:21 a.m. UTC | #4
On Wed, Jun 27, 2012 at 11:49:58AM +0900, Minchan Kim wrote:
> Hi Greg,
> 
> On 06/27/2012 11:43 AM, Greg Kroah-Hartman wrote:
> 
> > On Wed, Jun 27, 2012 at 11:37:25AM +0900, Minchan Kim wrote:
> >> On 06/26/2012 01:14 AM, Seth Jennings wrote:
> >>
> >>> This patch switches zcache and zram dependency to ZSMALLOC
> >>> rather than X86.  There is no net change since ZSMALLOC
> >>> depends on X86, however, this prevent further changes to
> >>> these files as zsmalloc dependencies change.
> >>>
> >>> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> >>
> >> Reviewed-by: Minchan Kim <minchan@kernel.org>
> >>
> >> It could be merged regardless of other patches in this series.
> > 
> > I already did :)
> 
> 
> It would have been better if you send merge mail to Ccing people.
> Anyway, Thanks!

I do, for people on the cc: in the signed-off-by area of the patch.  For
me to manually add the people on the cc: of the email, I would have to
modify git to add them to the commit somehow, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Konrad Rzeszutek Wilk June 27, 2012, 3:40 p.m. UTC | #5
On Tue, Jun 26, 2012 at 08:21:01PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Jun 27, 2012 at 11:49:58AM +0900, Minchan Kim wrote:
> > Hi Greg,
> > 
> > On 06/27/2012 11:43 AM, Greg Kroah-Hartman wrote:
> > 
> > > On Wed, Jun 27, 2012 at 11:37:25AM +0900, Minchan Kim wrote:
> > >> On 06/26/2012 01:14 AM, Seth Jennings wrote:
> > >>
> > >>> This patch switches zcache and zram dependency to ZSMALLOC
> > >>> rather than X86.  There is no net change since ZSMALLOC
> > >>> depends on X86, however, this prevent further changes to
> > >>> these files as zsmalloc dependencies change.
> > >>>
> > >>> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> > >>
> > >> Reviewed-by: Minchan Kim <minchan@kernel.org>
> > >>
> > >> It could be merged regardless of other patches in this series.
> > > 
> > > I already did :)
> > 
> > 
> > It would have been better if you send merge mail to Ccing people.
> > Anyway, Thanks!
> 
> I do, for people on the cc: in the signed-off-by area of the patch.  For
> me to manually add the people on the cc: of the email, I would have to
> modify git to add them to the commit somehow, sorry.

Is that some other script you have that does that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Konrad Rzeszutek Wilk June 27, 2012, 6:52 p.m. UTC | #6
> > > > It would have been better if you send merge mail to Ccing people.
> > > > Anyway, Thanks!
> > > 
> > > I do, for people on the cc: in the signed-off-by area of the patch.  For
> > > me to manually add the people on the cc: of the email, I would have to
> > > modify git to add them to the commit somehow, sorry.
> > 
> > Is that some other script you have that does that?
> 
> I don't understand what you are asking here.
> 
> My workflow is:
> 	- apply patches to a branch and test
> 	- if good, 'git format-patch' to create the patches
> 	- merge to my upstream branch and push out publically
> 	- run script on the patches generated by 'git format-patch' to
> 	  say they have been applied.
> 
> My custom script is the last thing there, that takes the patches, finds
> the email addresses in the patch, and notifies everyone.

That custom script - is it available somewhere?

> 
> Does that explain things better?

Aye!
> 
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Greg KH June 27, 2012, 6:55 p.m. UTC | #7
On Wed, Jun 27, 2012 at 11:40:03AM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Jun 26, 2012 at 08:21:01PM -0700, Greg Kroah-Hartman wrote:
> > On Wed, Jun 27, 2012 at 11:49:58AM +0900, Minchan Kim wrote:
> > > Hi Greg,
> > > 
> > > On 06/27/2012 11:43 AM, Greg Kroah-Hartman wrote:
> > > 
> > > > On Wed, Jun 27, 2012 at 11:37:25AM +0900, Minchan Kim wrote:
> > > >> On 06/26/2012 01:14 AM, Seth Jennings wrote:
> > > >>
> > > >>> This patch switches zcache and zram dependency to ZSMALLOC
> > > >>> rather than X86.  There is no net change since ZSMALLOC
> > > >>> depends on X86, however, this prevent further changes to
> > > >>> these files as zsmalloc dependencies change.
> > > >>>
> > > >>> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> > > >>
> > > >> Reviewed-by: Minchan Kim <minchan@kernel.org>
> > > >>
> > > >> It could be merged regardless of other patches in this series.
> > > > 
> > > > I already did :)
> > > 
> > > 
> > > It would have been better if you send merge mail to Ccing people.
> > > Anyway, Thanks!
> > 
> > I do, for people on the cc: in the signed-off-by area of the patch.  For
> > me to manually add the people on the cc: of the email, I would have to
> > modify git to add them to the commit somehow, sorry.
> 
> Is that some other script you have that does that?

I don't understand what you are asking here.

My workflow is:
	- apply patches to a branch and test
	- if good, 'git format-patch' to create the patches
	- merge to my upstream branch and push out publically
	- run script on the patches generated by 'git format-patch' to
	  say they have been applied.

My custom script is the last thing there, that takes the patches, finds
the email addresses in the patch, and notifies everyone.

Does that explain things better?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Greg KH June 27, 2012, 7:29 p.m. UTC | #8
On Wed, Jun 27, 2012 at 02:52:23PM -0400, Konrad Rzeszutek Wilk wrote:
> > > > > It would have been better if you send merge mail to Ccing people.
> > > > > Anyway, Thanks!
> > > > 
> > > > I do, for people on the cc: in the signed-off-by area of the patch.  For
> > > > me to manually add the people on the cc: of the email, I would have to
> > > > modify git to add them to the commit somehow, sorry.
> > > 
> > > Is that some other script you have that does that?
> > 
> > I don't understand what you are asking here.
> > 
> > My workflow is:
> > 	- apply patches to a branch and test
> > 	- if good, 'git format-patch' to create the patches
> > 	- merge to my upstream branch and push out publically
> > 	- run script on the patches generated by 'git format-patch' to
> > 	  say they have been applied.
> > 
> > My custom script is the last thing there, that takes the patches, finds
> > the email addresses in the patch, and notifies everyone.
> 
> That custom script - is it available somewhere?

It's right here:
	https://github.com/gregkh/gregkh-linux/blob/master/work/do.sh
along with other scripts that I use for kernel patch development, feel
free to use them if you like.

Note, this script does all of the above steps except apply the patches,
I got tired of running 3 scripts so I merged them into one.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
index 7048e01..4881839 100644
--- a/drivers/staging/zcache/Kconfig
+++ b/drivers/staging/zcache/Kconfig
@@ -1,9 +1,6 @@ 
 config ZCACHE
 	bool "Dynamic compression of swap pages and clean pagecache pages"
-	# X86 dependency is because zsmalloc uses non-portable pte/tlb
-	# functions
-	depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
-	select ZSMALLOC
+	depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && ZSMALLOC=y
 	select CRYPTO_LZO
 	default n
 	help
diff --git a/drivers/staging/zram/Kconfig b/drivers/staging/zram/Kconfig
index 9d11a4c..be5abe8 100644
--- a/drivers/staging/zram/Kconfig
+++ b/drivers/staging/zram/Kconfig
@@ -1,9 +1,6 @@ 
 config ZRAM
 	tristate "Compressed RAM block device support"
-	# X86 dependency is because zsmalloc uses non-portable pte/tlb
-	# functions
-	depends on BLOCK && SYSFS && X86
-	select ZSMALLOC
+	depends on BLOCK && SYSFS && ZSMALLOC
 	select LZO_COMPRESS
 	select LZO_DECOMPRESS
 	default n