linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesper Juhl <jj@chaosbits.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
	Marcos Paulo de Souza <marcos.mage@gmail.com>,
	trivial@kernel.org, Forest Bond <forest@alittletooquiet.net>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/7] staging: vt6656: int.c: Put comment about DEBUG print define on same line as code
Date: Wed, 27 Jun 2012 22:01:18 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1206272200460.6908@swampdragon.chaosbits.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1206272158130.6908@swampdragon.chaosbits.net>

A small comment at the end of the line, mentioning the debug level, is
enough - no need to repeat the entire line of code just for that.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 drivers/staging/vt6656/int.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vt6656/int.c b/drivers/staging/vt6656/int.c
index 36ed234..286ac3e 100644
--- a/drivers/staging/vt6656/int.c
+++ b/drivers/staging/vt6656/int.c
@@ -41,8 +41,7 @@
 #include "usbpipe.h"
 
 /*---------------------  Static Definitions -------------------------*/
-/* static int msglevel = MSG_LEVEL_DEBUG; */
-static int msglevel = MSG_LEVEL_INFO;
+static int msglevel = MSG_LEVEL_INFO; /* MSG_LEVEL_DEBUG */
 
 /*---------------------  Static Classes  ----------------------------*/
 
-- 
1.7.11.1


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.


  parent reply	other threads:[~2012-06-27 20:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-24 20:12 [PATCH] Staging: vt6656: int.c: A few trivial style cleanups Jesper Juhl
2012-06-25 17:47 ` Greg Kroah-Hartman
2012-06-27 19:58   ` Jesper Juhl
2012-06-27 20:00     ` [PATCH 1/7] staging: vt6656: int: Redundant blank line removal Jesper Juhl
2012-06-27 20:00     ` [PATCH 2/7] staging: vt6656: int.h: Fix indentation and spacing Jesper Juhl
2012-06-27 20:01     ` Jesper Juhl [this message]
2012-06-27 20:01     ` [PATCH 4/7] staging: vt6656: int.c: Remove unneeded cast Jesper Juhl
2012-06-27 20:02     ` [PATCH 5/7] staging: vt6656: int.c: Use one space between variable type and name Jesper Juhl
2012-06-27 20:02     ` [PATCH 6/7] staging: vt6656: int.c: We don't use spaces between a cast and the variable being converted Jesper Juhl
2012-06-27 20:03     ` [PATCH 7/7] staging: vt6656: int.c: correct indentation to use tabs rather than spaces Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1206272200460.6908@swampdragon.chaosbits.net \
    --to=jj@chaosbits.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcos.mage@gmail.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).