From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, JBottomley@parallels.com
Subject: [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number
Date: Mon, 16 Jul 2012 18:05:50 +0200 [thread overview]
Message-ID: <1342454751-8950-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1342454751-8950-1-git-send-email-pbonzini@redhat.com>
Hotplug/hot-unplug of a LUN whose number is greater than 255
uses the "flat" format for LUNs, which has bit 14 set. Clear
the bit when parsing the event structs.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
drivers/scsi/virtio_scsi.c | 8 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index c7030fb..c937232 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -252,13 +252,19 @@ static void virtscsi_cancel_event_work(struct virtio_scsi *vscsi)
cancel_work_sync(&vscsi->event_list[i].work);
}
+static unsigned int virtscsi_get_lun(u8 *lun_bytes)
+{
+ unsigned int lun = (lun_bytes[2] << 8) | lun_bytes[3];
+ return lun & 16383;
+}
+
static void virtscsi_handle_transport_reset(struct virtio_scsi *vscsi,
struct virtio_scsi_event *event)
{
struct scsi_device *sdev;
struct Scsi_Host *shost = virtio_scsi_host(vscsi->vdev);
unsigned int target = event->lun[1];
- unsigned int lun = (event->lun[2] << 8) | event->lun[3];
+ unsigned int lun = virtscsi_get_lun(event->lun);
switch (event->reason) {
case VIRTIO_SCSI_EVT_RESET_RESCAN:
--
1.7.1
next prev parent reply other threads:[~2012-07-16 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 16:05 [PATCH 0/2] virtio-scsi event changes for 3.6 Paolo Bonzini
2012-07-16 16:05 ` Paolo Bonzini [this message]
2012-07-26 8:52 ` [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number James Bottomley
2012-07-26 9:04 ` Paolo Bonzini
2012-07-26 9:21 ` James Bottomley
2012-07-26 9:27 ` Paolo Bonzini
2012-07-26 9:41 ` James Bottomley
2012-07-26 9:58 ` Paolo Bonzini
2012-07-26 10:17 ` Bart Van Assche
2012-07-26 10:33 ` James Bottomley
2012-07-26 10:43 ` Paolo Bonzini
2012-07-26 11:31 ` James Bottomley
2012-07-16 16:05 ` [PATCH 2/2] virtio-scsi: support online resizing of disks Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342454751-8950-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).