From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: [PATCH RESEND #2 2/3] tty: fix missing assignment
Date: Wed, 08 Aug 2012 16:29:17 +0100 [thread overview]
Message-ID: <20120808152808.8280.71771.stgit@localhost.localdomain> (raw)
In-Reply-To: <20120808152735.8280.54767.stgit@localhost.localdomain>
From: Dan Carpenter <dan.carpenter@oracle.com>
We're trying to save the termios state and we need to allocate a buffer
to do it. Smatch complains that the buffer is leaked at the end of the
function.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/tty/tty_io.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index c6f4d71..6087499 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1450,6 +1450,7 @@ void tty_free_termios(struct tty_struct *tty)
pr_warn("tty: no memory to save termios state.\n");
return;
}
+ tty->driver->termios[idx] = tp;
}
*tp = tty->termios;
}
next prev parent reply other threads:[~2012-08-08 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 15:27 [PATCH RESEND #2 1/3] serqt_usb2: drag screaming into the 21st century Alan Cox
2012-08-08 15:23 ` Greg KH
2012-08-08 15:29 ` Alan Cox [this message]
2012-08-08 15:29 ` [PATCH RESEND #2 3/3] tty: handle NULL parameters in free_tty_struct() Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808152808.8280.71771.stgit@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).