linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Len Brown <lenb@kernel.org>,
	Amit Daniel <amit.kachhap@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH -next] thermal: cpu_cooling.c needs to select CPU_FREQ_TABLE
Date: Wed, 12 Sep 2012 11:06:06 -0700	[thread overview]
Message-ID: <5050CF0E.3080502@xenotime.net> (raw)
In-Reply-To: <20120912184644.48e4e2e7d59b12893a42f60a@canb.auug.org.au>

From: Randy Dunlap <rdunlap@xenotime.net>

cpu_cooling.c (CONFIG_CPU_THERMAL) uses cpu frequency table
intefaces so it should select CPU_FREQ_TABLE.
Fixes these build errors:

drivers/built-in.o: In function `cpufreq_get_max_state':
cpu_cooling.c:(.text+0x4e1297): undefined reference to `cpufreq_frequency_get_table'
drivers/built-in.o: In function `cpufreq_set_cur_state':
cpu_cooling.c:(.text+0x4e138b): undefined reference to `cpufreq_frequency_get_table'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Amit Daniel <amit.kachhap@linaro.org>
---
 drivers/thermal/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Also, please add info in the MAINTAINERS file for drivers/thermal/.

--- linux-next-20120912.orig/drivers/thermal/Kconfig
+++ linux-next-20120912/drivers/thermal/Kconfig
@@ -22,6 +22,7 @@ config THERMAL_HWMON
 config CPU_THERMAL
 	bool "generic cpu cooling support"
 	depends on THERMAL && CPU_FREQ
+	select CPU_FREQ_TABLE
 	help
 	  This implements the generic cpu cooling mechanism through frequency
 	  reduction, cpu hotplug and any other ways of reducing temperature. An

  reply	other threads:[~2012-09-12 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12  8:46 linux-next: Tree for Sept 12 Stephen Rothwell
2012-09-12 18:06 ` Randy Dunlap [this message]
2012-09-13  8:46   ` [PATCH -next] thermal: cpu_cooling.c needs to select CPU_FREQ_TABLE Amit Kachhap
2012-09-13  9:03     ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5050CF0E.3080502@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@linux-foundation.org \
    --cc=amit.kachhap@linaro.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).