From: Peter Samuelson <peter@cadcamlab.org>
To: Andries.Brouwer@cwi.nl, kaos@ocs.com.au
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
rmk@arm.linux.org.uk
Subject: [PATCH] silly [< >] and other excess
Date: Thu, 23 Nov 2000 10:14:31 -0600 [thread overview]
Message-ID: <20001123101431.T2918@wire.cadcamlab.org> (raw)
In-Reply-To: <UTC200011230224.DAA141466.aeb@aak.cwi.nl>
In-Reply-To: <UTC200011230224.DAA141466.aeb@aak.cwi.nl>; from Andries.Brouwer@cwi.nl on Thu, Nov 23, 2000 at 03:24:02AM +0100
[Alan Cox]
> > Thats because too many things get put on a line then.
> > And because we do [<foo>] [<bar>] not [<foo>][<bar>] ?
[Andries Brouwer]
> In the good old times we had foo bar for a total of 8*(8+1) = 72
> positions. Now we have [<foo>] [<bar>] which takes 8*(8+1+4) = 104
I've got it! Put multiple addresses within one set of [< >]. ksymoops
and klogd will require a small adjustment, of course.
The following show_stack() is 8 addrs per line, 79 columns. Comments?
Peter
--- arch/i386/kernel/traps.c.orig Mon Nov 13 01:44:02 2000
+++ arch/i386/kernel/traps.c Thu Nov 23 10:10:06 2000
@@ -126,7 +126,6 @@
printk("%08lx ", *stack++);
}
- printk("\nCall Trace: ");
stack = esp;
i = 1;
module_start = VMALLOC_START;
@@ -144,12 +143,17 @@
if (((addr >= (unsigned long) &_stext) &&
(addr <= (unsigned long) &_etext)) ||
((addr >= module_start) && (addr <= module_end))) {
- if (i && ((i % 8) == 0))
- printk("\n ");
- printk("[<%08lx>] ", addr);
+ if (i==1)
+ printk("\nCall Trace: [<");
+ else if ((i % 8)==0)
+ printk(">]\n [<");
+ else
+ printk(" ");
+ printk("%08lx", addr);
i++;
}
}
+ printk(">]\n");
}
static void show_registers(struct pt_regs *regs)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-11-23 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-23 2:24 silly [< >] and other excess Andries.Brouwer
2000-11-23 14:29 ` Charles Cazabon
2000-11-23 20:16 ` Tuomas Heino
2000-11-23 16:14 ` Peter Samuelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001123101431.T2918@wire.cadcamlab.org \
--to=peter@cadcamlab.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).