[2/6] xfrm_user: fix info leak in copy_to_user_state()
diff mbox series

Message ID 1348090423-32665-3-git-send-email-minipli@googlemail.com
State New, archived
Headers show
  • xfrm_user info leaks
Related show

Commit Message

Mathias Krause Sept. 19, 2012, 9:33 p.m. UTC
The memory reserved to dump the xfrm state includes the padding bytes of
struct xfrm_usersa_info added by the compiler for alignment (7 for
amd64, 3 for i386). Add an explicit memset(0) before filling the buffer
to avoid the info leak.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
 net/xfrm/xfrm_user.c |    1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index ba26423..c1f15b5 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -689,6 +689,7 @@  out:
 static void copy_to_user_state(struct xfrm_state *x, struct xfrm_usersa_info *p)
+	memset(p, 0, sizeof(*p));
 	memcpy(&p->id, &x->id, sizeof(p->id));
 	memcpy(&p->sel, &x->sel, sizeof(p->sel));
 	memcpy(&p->lft, &x->lft, sizeof(p->lft));