Support compat_ioctl for block devices
diff mbox series

Message ID 20050118075602.GD76018@muc.de
State New, archived
Headers show
Series
  • Support compat_ioctl for block devices
Related show

Commit Message

Andi Kleen Jan. 18, 2005, 7:56 a.m. UTC
Support passing down of compat_ioctl on block devices.
This is needed for the compat_ioctl conversion of block drivers.

Signed-off-by: Andi Kleen <ak@muc.de>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Christoph Hellwig Jan. 18, 2005, 9:19 a.m. UTC | #1
> +long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg)
> +{
> +	struct block_device *bdev = file->f_dentry->d_inode->i_bdev;
> +	struct gendisk *disk = bdev->bd_disk;
> +	int ret = -ENOIOCTLCMD;
> +	if (disk->fops->compat_ioctl) {
> +		lock_kernel();
> +		ret = disk->fops->compat_ioctl(file, cmd, arg);
> +		unlock_kernel();
> +	}
> +	return ret;
> +}

 - please don't introduce a new API with the BKL held.
 - prototype isn't nice.  just passing the gendisk for block_device
   should be enough.

also this wants documentation in Documentation/filesystems/Locking
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Andi Kleen Jan. 18, 2005, 9:31 a.m. UTC | #2
On Tue, Jan 18, 2005 at 09:19:27AM +0000, Christoph Hellwig wrote:
> > +long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg)
> > +{
> > +	struct block_device *bdev = file->f_dentry->d_inode->i_bdev;
> > +	struct gendisk *disk = bdev->bd_disk;
> > +	int ret = -ENOIOCTLCMD;
> > +	if (disk->fops->compat_ioctl) {
> > +		lock_kernel();
> > +		ret = disk->fops->compat_ioctl(file, cmd, arg);
> > +		unlock_kernel();
> > +	}
> > +	return ret;
> > +}
> 
>  - please don't introduce a new API with the BKL held.

Nope, I'm not going to audit zillions of low level functions for this.

>  - prototype isn't nice.  just passing the gendisk for block_device
>    should be enough.

No, it isn't, the compat handler needs cmd and arg, and file is useful
when you pass it to an existing ioctl handler.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Christoph Hellwig Jan. 18, 2005, 9:36 a.m. UTC | #3
On Tue, Jan 18, 2005 at 10:31:58AM +0100, Andi Kleen wrote:
> >  - please don't introduce a new API with the BKL held.
> 
> Nope, I'm not going to audit zillions of low level functions for this.

So just stick a lock_kernel() unlock_kernel() into the handler, it's
not like there's more than a handfull of them.

> >  - prototype isn't nice.  just passing the gendisk for block_device
> >    should be enough.
> 
> No, it isn't, the compat handler needs cmd and arg, and file is useful
> when you pass it to an existing ioctl handler.

cmd/arg is needed, file shouldn't.  If you care for the underlying handler
add a version that doesn't take the file * either.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Andi Kleen Jan. 18, 2005, 9:51 a.m. UTC | #4
On Tue, Jan 18, 2005 at 09:36:45AM +0000, Christoph Hellwig wrote:
> On Tue, Jan 18, 2005 at 10:31:58AM +0100, Andi Kleen wrote:
> > >  - please don't introduce a new API with the BKL held.
> > 
> > Nope, I'm not going to audit zillions of low level functions for this.
> 
> So just stick a lock_kernel() unlock_kernel() into the handler, it's
> not like there's more than a handfull of them.

Hmm, possible, although it tends to be quite ugly (requiring
either gotos or wrappers). But ok.

> 
> > >  - prototype isn't nice.  just passing the gendisk for block_device
> > >    should be enough.
> > 
> > No, it isn't, the compat handler needs cmd and arg, and file is useful
> > when you pass it to an existing ioctl handler.
> 
> cmd/arg is needed, file shouldn't.  If you care for the underlying handler
> add a version that doesn't take the file * either.

Sorry, that didn't make any sense.  

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

diff -u linux-2.6.11-rc1-bk4/drivers/block/ioctl.c-o linux-2.6.11-rc1-bk4/drivers/block/ioctl.c
--- linux-2.6.11-rc1-bk4/drivers/block/ioctl.c-o	2004-10-19 01:55:10.000000000 +0200
+++ linux-2.6.11-rc1-bk4/drivers/block/ioctl.c	2005-01-18 03:53:40.000000000 +0100
@@ -3,6 +3,7 @@ 
 #include <linux/blkpg.h>
 #include <linux/backing-dev.h>
 #include <linux/buffer_head.h>
+#include <linux/smp_lock.h>
 #include <asm/uaccess.h>
 
 static int blkpg_ioctl(struct block_device *bdev, struct blkpg_ioctl_arg __user *arg)
@@ -220,3 +221,19 @@ 
 	}
 	return -ENOTTY;
 }
+
+/* Most of the generic ioctls are handled in the normal fallback path.
+   This assumes the blkdev's low level compat_ioctl always returns
+   ENOIOCTLCMD for unknown ioctls. */
+long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg)
+{
+	struct block_device *bdev = file->f_dentry->d_inode->i_bdev;
+	struct gendisk *disk = bdev->bd_disk;
+	int ret = -ENOIOCTLCMD;
+	if (disk->fops->compat_ioctl) {
+		lock_kernel();
+		ret = disk->fops->compat_ioctl(file, cmd, arg);
+		unlock_kernel();
+	}
+	return ret;
+}
diff -u linux-2.6.11-rc1-bk4/fs/block_dev.c-o linux-2.6.11-rc1-bk4/fs/block_dev.c
--- linux-2.6.11-rc1-bk4/fs/block_dev.c-o	2005-01-04 12:13:13.000000000 +0100
+++ linux-2.6.11-rc1-bk4/fs/block_dev.c	2005-01-18 07:26:45.000000000 +0100
@@ -804,6 +804,9 @@ 
 	.mmap		= generic_file_mmap,
 	.fsync		= block_fsync,
 	.ioctl		= block_ioctl,
+#ifdef CONFIG_COMPAT
+	.compat_ioctl	= compat_blkdev_ioctl,
+#endif
 	.readv		= generic_file_readv,
 	.writev		= generic_file_write_nolock,
 	.sendfile	= generic_file_sendfile,
diff -u linux-2.6.11-rc1-bk4/include/linux/fs.h-o linux-2.6.11-rc1-bk4/include/linux/fs.h
--- linux-2.6.11-rc1-bk4/include/linux/fs.h-o	2005-01-17 10:39:41.000000000 +0100
+++ linux-2.6.11-rc1-bk4/include/linux/fs.h	2005-01-18 04:54:29.000000000 +0100
@@ -879,6 +879,7 @@ 
 	int (*open) (struct inode *, struct file *);
 	int (*release) (struct inode *, struct file *);
 	int (*ioctl) (struct inode *, struct file *, unsigned, unsigned long);
+	long (*compat_ioctl) (struct file *, unsigned, unsigned long);
 	int (*media_changed) (struct gendisk *);
 	int (*revalidate_disk) (struct gendisk *);
 	struct module *owner;
@@ -1291,6 +1292,7 @@ 
 extern struct file_operations def_fifo_fops;
 extern int ioctl_by_bdev(struct block_device *, unsigned, unsigned long);
 extern int blkdev_ioctl(struct inode *, struct file *, unsigned, unsigned long);
+extern long compat_blkdev_ioctl(struct file *, unsigned, unsigned long);
 extern int blkdev_get(struct block_device *, mode_t, unsigned);
 extern int blkdev_put(struct block_device *);
 extern int bd_claim(struct block_device *, void *);