From: Val Henson <val@nmt.edu>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Yellowfin bug fix for Symbios cards
Date: Thu, 18 Oct 2001 21:04:16 -0600 [thread overview]
Message-ID: <20011018210416.D17208@boardwalk> (raw)
Short version: My last patch to the yellowfin driver forced
full-duplex on for Symbios 10/100 cards, causing severe packet loss on
hubs and some switches.
Long version: Reading the MAC address from the EEPROM didn't work on
the Symbios card, so I turned on the IsGigabit flag to read it
correctly. This also forces full-duplex on, which is wrong. So I
added a flag controlling only the MAC address reading behavior and
turned off the IsGigabit flag for Symbios cards.
Patch (against latest 2.4) is at the end of this mail.
Thanks to Tim Moloney for reporting this bug.
-VAL
diff -Nru a/drivers/net/yellowfin.c b/drivers/net/yellowfin.c
--- a/drivers/net/yellowfin.c Thu Oct 18 20:59:43 2001
+++ b/drivers/net/yellowfin.c Thu Oct 18 20:59:43 2001
@@ -38,10 +38,13 @@
* Fix three endian-ness bugs
* Support dual function SYM53C885E ethernet chip
+ LK1.1.5 (val@nmt.edu):
+ * Fix forced full-duplex bug I introduced
+
*/
#define DRV_NAME "yellowfin"
-#define DRV_VERSION "1.05+LK1.1.3"
+#define DRV_VERSION "1.05+LK1.1.5"
#define DRV_RELDATE "May 10, 2001"
#define PFX DRV_NAME ": "
@@ -256,7 +259,7 @@
};
enum capability_flags {
HasMII=1, FullTxStatus=2, IsGigabit=4, HasMulticastBug=8, FullRxStatus=16,
- HasMACAddrBug=32, /* Only on early revs. */
+ HasMACAddrBug=32, DontUseEeprom=64, /* Only on early revs. */
};
/* The PCI I/O space extent. */
#define YELLOWFIN_SIZE 0x100
@@ -282,7 +285,7 @@
PCI_IOTYPE, YELLOWFIN_SIZE,
FullTxStatus | IsGigabit | HasMulticastBug | HasMACAddrBug},
{"Symbios SYM83C885", { 0x07011000, 0xffffffff},
- PCI_IOTYPE, YELLOWFIN_SIZE, HasMII | IsGigabit | FullTxStatus },
+ PCI_IOTYPE, YELLOWFIN_SIZE, HasMII | DontUseEeprom },
{0,},
};
@@ -453,7 +456,7 @@
#endif
irq = pdev->irq;
- if (drv_flags & IsGigabit)
+ if (drv_flags & DontUseEeprom)
for (i = 0; i < 6; i++)
dev->dev_addr[i] = inb(ioaddr + StnAddr + i);
else {
next reply other threads:[~2001-10-19 3:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-19 3:04 Val Henson [this message]
2001-10-19 3:37 ` [PATCH] Yellowfin bug fix for Symbios cards Jeff Garzik
2001-10-19 3:54 ` Val Henson
2001-10-19 4:26 ` Jeff Garzik
2001-10-19 18:06 ` Val Henson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011018210416.D17208@boardwalk \
--to=val@nmt.edu \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).