linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: PATCH 2.4.0.10.6: always no-strict-aliasing
Date: Fri, 27 Oct 2000 04:34:40 -0400	[thread overview]
Message-ID: <39F93E20.EC1C2D9@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.10.10010262345530.1231-100000@penguin.transmeta.com>

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Linus Torvalds wrote:
>  (a) the new compiler requirements (sorry, but it turned out that 2.7.2.3
>      really is too subtly broken with named structure initializers that
>      are very heavily used these days inside the kernel)
> 
>      Suggested stable compiler: gcc-2.91.66, aka egcs-1.1.2, which is the
>      one most vendors have been shipping for a long time, and while sure
>      to be buggy too has not been found to be seriously so at least yet.
> 
>      Other modern gcc versions may well work too.

Since egcs-1.1.2 supports -fno-strict-aliasing, would the attached patch
against linux/Makefile be appropriate?

-- 
Jeff Garzik                    | Raft naked...
Building 1024                  | It adds color to your cheeks.
MandrakeSoft                   |

[-- Attachment #2: makefile.patch --]
[-- Type: text/plain, Size: 1129 bytes --]

Index: Makefile
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/Makefile,v
retrieving revision 1.1.1.11
diff -u -r1.1.1.11 Makefile
--- Makefile	2000/10/22 23:14:50	1.1.1.11
+++ Makefile	2000/10/27 08:32:28
@@ -16,7 +16,7 @@
 FINDHPATH	= $(HPATH)/asm $(HPATH)/linux $(HPATH)/scsi $(HPATH)/net
 
 HOSTCC  	= gcc
-HOSTCFLAGS	= -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS	= -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing
 
 CROSS_COMPILE 	=
 
@@ -87,7 +87,7 @@
 
 CPPFLAGS := -D__KERNEL__ -I$(HPATH)
 
-CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing
 AFLAGS := -D__ASSEMBLY__ $(CPPFLAGS)
 
 #
@@ -181,9 +181,6 @@
 DRIVERS += $(DRIVERS-y)
 
 include arch/$(ARCH)/Makefile
-
-# use '-fno-strict-aliasing', but only if the compiler can take it
-CFLAGS += $(shell if $(CC) -fno-strict-aliasing -S -o /dev/null -xc /dev/null >/dev/null 2>&1; then echo "-fno-strict-aliasing"; fi)
 
 export	CPPFLAGS CFLAGS AFLAGS
 

      parent reply	other threads:[~2000-10-27  8:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-10-27  6:58 test10-pre6 Linus Torvalds
2000-10-27  8:27 ` test10-pre6 Jeff V. Merkey
2000-10-27  8:34 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39F93E20.EC1C2D9@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).