@@ -3213,21 +3213,29 @@ sub process {
$herecurr);
}
-# check for needless kfree() checks
+# check for needless "if"
if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
my $expr = $1;
+# check for needless kfree() checks
if ($line =~ /\bkfree\(\Q$expr\E\);/) {
WARN("NEEDLESS_KFREE",
"kfree(NULL) is safe this check is probably not required\n" . $hereprev);
}
- }
# check for needless usb_free_urb() checks
- if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
- my $expr = $1;
if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
WARN("NEEDLESS_USB_FREE_URB",
"usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
}
+# check for needless debugfs_remove() checks
+ if ($line =~ /\bdebugfs_remove\(\Q$expr\E\);/) {
+ WARN("NEEDLESS_DEBUGFS_REMOVE",
+ "debugfs_remove(NULL) is safe this check is probably not required\n" . $hereprev);
+ }
+# check for needless debugfs_remove_recursive() checks
+ if ($line =~ /\bdebugfs_remove_recursive\(\Q$expr\E\);/) {
+ WARN("NEEDLESS_DEBUGFS_REMOVE",
+ "debugfs_remove_recursive(NULL) is safe this check is probably not required\n" . $hereprev);
+ }
}
# prefer usleep_range over udelay