From: Constantine Shulyupin <const@MakeLinux.com>
To: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
Andy Whitcroft <apw@canonical.com>,
joe@perches.com
Cc: Constantine Shulyupin <const@MakeLinux.com>
Subject:
Date: Sat, 17 Nov 2012 16:32:24 +0200 [thread overview]
Message-ID: <1353162744-489-1-git-send-email-const@MakeLinux.com> (raw)
>From 21f1095ce30b21f1729c64eb26b7921bbb3bcc8d Mon Sep 17 00:00:00 2001
From: Constantine Shulyupin <const@MakeLinux.com>
Date: Sat, 17 Nov 2012 14:27:18 +0200
Subject: [PATCH v2] checkpatch: debugfs_remove() can take NULL
debugfs_remove() and debugfs_remove_recursive() can take a NULL, so let's check and warn about that.
Channegs since v1:
- added debugfs_remove_recursive
- all tests for pattenrs are "if (a) xxx(a)" are consolidates
Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
---
scripts/checkpatch.pl | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f18750e..2339b54 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3213,21 +3213,29 @@ sub process {
$herecurr);
}
-# check for needless kfree() checks
+# check for needless "if"
if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
my $expr = $1;
+# check for needless kfree() checks
if ($line =~ /\bkfree\(\Q$expr\E\);/) {
WARN("NEEDLESS_KFREE",
"kfree(NULL) is safe this check is probably not required\n" . $hereprev);
}
- }
# check for needless usb_free_urb() checks
- if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
- my $expr = $1;
if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
WARN("NEEDLESS_USB_FREE_URB",
"usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
}
+# check for needless debugfs_remove() checks
+ if ($line =~ /\bdebugfs_remove\(\Q$expr\E\);/) {
+ WARN("NEEDLESS_DEBUGFS_REMOVE",
+ "debugfs_remove(NULL) is safe this check is probably not required\n" . $hereprev);
+ }
+# check for needless debugfs_remove_recursive() checks
+ if ($line =~ /\bdebugfs_remove_recursive\(\Q$expr\E\);/) {
+ WARN("NEEDLESS_DEBUGFS_REMOVE",
+ "debugfs_remove_recursive(NULL) is safe this check is probably not required\n" . $hereprev);
+ }
}
# prefer usleep_range over udelay
--
1.7.9.5
reply other threads:[~2012-11-17 14:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353162744-489-1-git-send-email-const@MakeLinux.com \
--to=const@makelinux.com \
--cc=apw@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).