From: Paul Menzel <paulepanter@users.sourceforge.net>
To: Takahisa Tanaka <mc74hc00@gmail.com>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
Arkadiusz Miskiewicz <arekm@maven.pl>,
Bjorn Helgaas <bhelgaas@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Nieder <jrnieder@gmail.com>,
linux-kernel@vger.kernel.org,
Florian Mickler <florian@mickler.org>,
Joseph Salisbury <joseph.salisbury@canonical.com>,
Joseph Salisbury <josephtsalisbury@gmail.com>
Subject: [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2
Date: Sun, 03 Mar 2013 10:10:36 +0100 [thread overview]
Message-ID: <1362301836.13011.8.camel@mattotaupa> (raw)
In-Reply-To: <1362289680-3527-1-git-send-email-mc74hc00@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]
From: Takahisa Tanaka <mc74hc00@gmail.com>
Date: Sun, 3 Mar 2013 14:48:00 +0900
The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current
sp5100_tco driver is using bit 2.
See 2.3.3 Power Management (PM) Registers page 150 of the
AMD SB800-Series Southbridges Register Reference Guide [1].
AcpiMmioEn - RW – 8/16/32 bits - [PM_Reg: 24h]
Field Name Bits Default Description
AcpiMMioDecodeEn 0 0b Set to 1 to enable AcpiMMio space.
AcpiMMIoSel 1 0b Set AcpiMMio registers to be memory-mapped or IO-mapped space.
0: Memory-mapped space
1: I/O-mapped space
The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit 1).
Fortunately, no problems were caused by this typo, because the default
value of the undocumented misused bit 2 seems to be zero.
However, the sp5100_tco driver should use the correct bitmask value.
[1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf
Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
CC: stable@vger.kernel.org
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
v2: Hopefully improved the commit message.
drivers/watchdog/sp5100_tco.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h
index 71594a0..2b28c00 100644
--- a/drivers/watchdog/sp5100_tco.h
+++ b/drivers/watchdog/sp5100_tco.h
@@ -57,7 +57,7 @@
#define SB800_PM_WATCHDOG_DISABLE (1 << 2)
#define SB800_PM_WATCHDOG_SECOND_RES (3 << 0)
#define SB800_ACPI_MMIO_DECODE_EN (1 << 0)
-#define SB800_ACPI_MMIO_SEL (1 << 2)
+#define SB800_ACPI_MMIO_SEL (1 << 1)
#define SB800_PM_WDT_MMIO_OFFSET 0xB00
--
1.7.10.4
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-03-03 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 5:48 [PATCH] sp5100_tco: Fix the AcpiMmioSel bitmask value Takahisa Tanaka
2013-03-03 9:10 ` Paul Menzel [this message]
2013-03-07 12:17 ` [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2 Tanaka Takahisa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362301836.13011.8.camel@mattotaupa \
--to=paulepanter@users.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=arekm@maven.pl \
--cc=bhelgaas@google.com \
--cc=florian@mickler.org \
--cc=joseph.salisbury@canonical.com \
--cc=josephtsalisbury@gmail.com \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mc74hc00@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).