From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: linuxppc-embedded@ozlabs.org, linux-kernel@vger.kernel.org
Subject: {PATCH] Fix IBM EMAC driver ioctl bug
Date: Thu, 14 Apr 2005 11:20:32 -0700 [thread overview]
Message-ID: <425EB470.9040203@am.sony.com> (raw)
Fix IBM EMAC driver ioctl bug.
I found IBM EMAC driver bug.
So mii-tool command print wrong status.
# mii-tool
eth0: 10 Mbit, half duplex, no link
eth1: 10 Mbit, half duplex, no link
I can get correct status on fixed kernel.
# mii-tool
eth0: negotiated 100baseTx-FD, link okZZ
eth1: negotiated 100baseTx-FD, link ok
Hiroaki Fuse
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> for CELF
---
Index: linux-2.6.11/drivers/net/ibm_emac/ibm_emac_core.c
===================================================================
--- linux-2.6.11.orig/drivers/net/ibm_emac/ibm_emac_core.c 2005-04-14 10:54:20.014023550 -0700
+++ linux-2.6.11/drivers/net/ibm_emac/ibm_emac_core.c 2005-04-14 10:55:24.723458722 -0700
@@ -1587,7 +1587,7 @@
static int emac_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
{
struct ocp_enet_private *fep = dev->priv;
- uint *data = (uint *) & rq->ifr_ifru;
+ uint16_t *data = (uint16_t *) & rq->ifr_ifru;
switch (cmd) {
case SIOCGMIIPHY:
-EOF
next reply other threads:[~2005-04-14 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-14 18:20 Geoff Levand [this message]
2005-04-15 4:01 ` {PATCH] Fix IBM EMAC driver ioctl bug Eugene Surovegin
2005-05-16 2:44 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425EB470.9040203@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).