From: Neil Brown <neilb@cse.unsw.edu.au>
To: Linus Torvalds <torvalds@transmeta.com>, V Ganesh <ganesh@veritas.com>
Cc: linux-kernel@vger.kernel.org, linux-LVM@EZ-Darmstadt.Telekom.de,
mingo@redhat.com
Subject: [PATCH] Re: [bug] infinite loop in generic_make_request()
Date: Thu, 30 Nov 2000 20:24:23 +1100 (EST) [thread overview]
Message-ID: <14886.7367.247491.267120@notabene.cse.unsw.edu.au> (raw)
In-Reply-To: message from V Ganesh on Thursday November 30
In-Reply-To: <200011300702.MAA26287@vxindia.veritas.com>
On Thursday November 30, ganesh@veritas.com wrote:
> [cc'ed to maintainers of md and lvm]
>
> hi,
> in generic_make_request(), the following code handles stacking:
>
> do {
> q = blk_get_queue(bh->b_rdev);
> if (!q) {
> printk(...)
> buffer_IO_error(bh);
> break;
> }
> } while (q->make_request_fn(q, rw, bh));
>
> however, make_request_fn may return -1 in case of errors. one such fn is
> raid0_make_request(). this causes generic_make_request() to loop endlessly.
> lvm returns 1 unconditionally, so it would also loop if an error occured in
> lvm_map(). other bdevs might have the same problem.
> I think a better mechanism would be to mandate that make_request_fn ought
> to call bh->b_end_io() in case of errors and return 0.
>
> ganesh
Good catch, thanks. Below is a patch to fix md drivers (md.c,
linear.c and raid0.c).
NeilBrown
--- ./drivers/md/md.c 2000/11/30 08:23:51 1.2
+++ ./drivers/md/md.c 2000/11/30 09:20:05 1.3
@@ -179,7 +179,7 @@
return mddev->pers->make_request(mddev, rw, bh);
else {
buffer_IO_error(bh);
- return -1;
+ return 0;
}
}
--- ./drivers/md/linear.c 2000/11/30 08:23:51 1.2
+++ ./drivers/md/linear.c 2000/11/30 09:20:05 1.3
@@ -136,7 +136,8 @@
if (!hash->dev1) {
printk ("linear_make_request : hash->dev1==NULL for block %ld\n",
block);
- return -1;
+ buffer_IO_error(bh);
+ return 0;
}
tmp_dev = hash->dev1;
} else
@@ -145,7 +146,8 @@
if (block >= (tmp_dev->size + tmp_dev->offset)
|| block < tmp_dev->offset) {
printk ("linear_make_request: Block %ld out of bounds on dev %s size %ld offset %ld\n", block, kdevname(tmp_dev->dev), tmp_dev->size, tmp_dev->offset);
- return -1;
+ buffer_IO_error(bh);
+ return 0;
}
bh->b_rdev = tmp_dev->dev;
bh->b_rsector = bh->b_rsector - (tmp_dev->offset << 1);
--- ./drivers/md/raid0.c 2000/11/30 08:23:51 1.2
+++ ./drivers/md/raid0.c 2000/11/30 09:20:05 1.3
@@ -275,16 +275,18 @@
bad_map:
printk ("raid0_make_request bug: can't convert block across chunks or bigger than %dk %ld %d\n", chunk_size, bh->b_rsector, bh->b_size >> 10);
- return -1;
+ goto outerr;
bad_hash:
printk("raid0_make_request bug: hash==NULL for block %ld\n", block);
- return -1;
+ goto outerr;
bad_zone0:
printk ("raid0_make_request bug: hash->zone0==NULL for block %ld\n", block);
- return -1;
+ goto outerr;
bad_zone1:
printk ("raid0_make_request bug: hash->zone1==NULL for block %ld\n", block);
- return -1;
+ outerr:
+ buffer_IO_error(bh);
+ return 0;
}
static int raid0_status (char *page, mddev_t *mddev)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-30 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-30 7:02 [bug] infinite loop in generic_make_request() V Ganesh
2000-11-30 9:24 ` Neil Brown [this message]
2000-11-30 20:05 ` [PATCH] " Andreas Dilger
2000-11-30 20:41 ` Andrea Arcangeli
2000-11-30 21:54 ` Andreas Dilger
2000-11-30 22:17 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14886.7367.247491.267120@notabene.cse.unsw.edu.au \
--to=neilb@cse.unsw.edu.au \
--cc=ganesh@veritas.com \
--cc=linux-LVM@EZ-Darmstadt.Telekom.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).