From: Andrew Morton <akpm@osdl.org>
To: stable@kernel.org, linux-kernel@vger.kernel.org
Subject: Fw: [PATCH] bio_clone fix
Date: Thu, 28 Jul 2005 11:02:26 -0700 [thread overview]
Message-ID: <20050728110226.4fa98645.akpm@osdl.org> (raw)
This is an important fix affecting both 2.6.11 and 2.6.12. Anyone who is
experiencing data loss issues on MD or DM setups with those kernels should
apply.
Begin forwarded message:
Date: Thu, 28 Jul 2005 10:31:10 -0700
From: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
To: bk-commits-head@vger.kernel.org
Subject: [PATCH] bio_clone fix
tree c1d224f0fb4db22e87567e1eea45001a7b11e51f
parent 577a4f8102d54b504cb22eb021b89e957e8df18f
author Andrew Morton <akpm@osdl.org> Thu, 28 Jul 2005 15:07:18 -0700
committer Linus Torvalds <torvalds@g5.osdl.org> Thu, 28 Jul 2005 22:38:59 -0700
[PATCH] bio_clone fix
Fix bug introduced in 2.6.11-rc2: when we clone a BIO we need to copy over the
current index into it as well.
It corrupts data with some MD setups.
See http://bugzilla.kernel.org/show_bug.cgi?id=4946
Huuuuuuuuge thanks to Matthew Stapleton <matthew4196@gmail.com> for doggedly
chasing this one down.
Acked-by: Jens Axboe <axboe@suse.de>
Cc: <linux-raid@vger.kernel.org>
Cc: <dm-devel@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/bio.c | 1 +
1 files changed, 1 insertion(+)
diff --git a/fs/bio.c b/fs/bio.c
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -261,6 +261,7 @@ inline void __bio_clone(struct bio *bio,
*/
bio->bi_vcnt = bio_src->bi_vcnt;
bio->bi_size = bio_src->bi_size;
+ bio->bi_idx = bio_src->bi_idx;
bio_phys_segments(q, bio);
bio_hw_segments(q, bio);
}
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2005-07-28 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-28 18:02 Andrew Morton [this message]
2005-07-28 18:22 ` Fw: [PATCH] bio_clone fix Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050728110226.4fa98645.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).