From: "Stephen C. Tweedie" <sct@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Stephen Tweedie <sct@redhat.com>, Andi Kleen <ak@muc.de>,
Andrea Arcangeli <andrea@suse.de>,
wtenhave@sybase.com, hdeller@redhat.com,
Eric Lowe <elowe@myrile.madriver.k12.oh.us>,
Larry Woodman <woodman@missioncriticallinux.com>,
linux-mm@kvack.org
Subject: New patches for 2.2.18pre24 raw IO (fix for bounce buffer copy)
Date: Mon, 4 Dec 2000 20:50:04 +0000 [thread overview]
Message-ID: <20001204205004.H8700@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
Hi,
I have pushed another set of raw IO patches out, this time to fix a
bug with bounce buffer copying when running on highmem boxes. It is
likely to affect any bounce buffer copies using non-page-aligned
accesses if both highmem and normal pages are involved in the kiobuf.
The specific new patch added in this patchset is attached below. The
full set has been uploaded as
kiobuf-2.2.18pre24-B.tar.gz
at
ftp.*.kernel.org:/pub/linux/kernel/people/sct/raw-io/
and ftp.uk.linux.org:/pub/linux/sct/fs/raw-io/
This one really should kill all known bugs, dead. Please stress it
out and let me know if anybody encounters any further problems. A
merge of all of the pending raw IO fixes into 2.4 should be happening
soon once the current VM changes for marking pages dirty are working.
Cheers,
Stephen
[-- Attachment #2: raw-2.2.18pre24.91.fix-bouncecopy --]
[-- Type: text/plain, Size: 509 bytes --]
--- linux-2.2.18pre24.raw.bigmem/fs/iobuf.c.~1~ Mon Dec 4 20:13:49 2000
+++ linux-2.2.18pre24.raw.bigmem/fs/iobuf.c Mon Dec 4 20:14:08 2000
@@ -211,10 +211,10 @@
unsigned long kin, kout;
int pagelen = length;
+ if ((pagelen+offset) > PAGE_SIZE)
+ pagelen = PAGE_SIZE - offset;
+
if (bounce_page) {
- if ((pagelen+offset) > PAGE_SIZE)
- pagelen = PAGE_SIZE - offset;
-
if (direction == COPY_TO_BOUNCE) {
kin = kmap(page, KM_READ);
kout = kmap(bounce_page, KM_WRITE);
next reply other threads:[~2000-12-04 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-04 20:50 Stephen C. Tweedie [this message]
2000-12-08 12:06 ` New patches for 2.2.18pre24 raw IO (fix for bounce buffer copy) Andrea Arcangeli
2000-12-15 16:13 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001204205004.H8700@redhat.com \
--to=sct@redhat.com \
--cc=ak@muc.de \
--cc=andrea@suse.de \
--cc=elowe@myrile.madriver.k12.oh.us \
--cc=hdeller@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=woodman@missioncriticallinux.com \
--cc=wtenhave@sybase.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).