From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Olaf Hering <olh@suse.de>, James Morris <jmorris@namei.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: [AES] Add module alias to x86_64 implementation
Date: Thu, 11 Aug 2005 22:28:35 +1000 [thread overview]
Message-ID: <20050811122834.GA21105@gondor.apana.org.au> (raw)
In-Reply-To: <Pine.LNX.4.63.0508090015230.20178@excalibur.intercode>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On Tue, Aug 09, 2005 at 12:16:18AM -0400, James Morris wrote:
>
> > > I cant test it due to lack of hardware. Will find someone who does.
> > > modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.
> >
> > This works, tested it. modprobe -v aes
> > insmod /lib/modules/2.6.13-rc6-3-default/kernel/arch/x86_64/crypto/aes-x86_64.ko
>
> It looks the same as the i386 version, so probably ok.
It looks good to me too. Andrew, please add this to 2.6.13:
Subject: [AES] Add module alias to x86_64 implementation
From: Olaf Hering <olh@suse.de>
modprobe aes does not work on x86_64. i386 has a similar line,
Signed-off-by: Olaf Hering <olh@suse.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 274 bytes --]
diff --git a/arch/x86_64/crypto/aes.c b/arch/x86_64/crypto/aes.c
--- a/arch/x86_64/crypto/aes.c
+++ b/arch/x86_64/crypto/aes.c
@@ -322,3 +322,4 @@ module_exit(aes_fini);
MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("aes");
next prev parent reply other threads:[~2005-08-11 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-08 17:33 [PATCH] add MODULE_ALIAS for x86_64 aes Olaf Hering
2005-08-08 17:51 ` Andrew Morton
2005-08-08 17:55 ` Olaf Hering
2005-08-08 20:10 ` Olaf Hering
2005-08-09 4:16 ` James Morris
2005-08-11 12:28 ` Herbert Xu [this message]
2005-08-11 22:35 ` [AES] Add module alias to x86_64 implementation David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050811122834.GA21105@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).