From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Toshi Kani <toshi.kani@hp.com>, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 3/3] ACPI / PCI root: Clear driver_data before failing enumeration
Date: Thu, 14 Nov 2013 00:17:49 +0100 [thread overview]
Message-ID: <6884617.gWRuZsFG3E@vostro.rjw.lan> (raw)
In-Reply-To: <2434673.zhjYZOTQ4A@vostro.rjw.lan>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
If a PCI host bridge cannot be enumerated due to an error in
pci_acpi_scan_root(), its ACPI device object's driver_data field
has to be cleared by acpi_pci_root_add() before freeing the
object pointed to by that field, or some later acpi_pci_find_root()
checks that should fail may succeed and cause quite a bit of
confusion to ensue.
Fix acpi_pci_root_add() to clear device->driver_data before
returning an error code as appropriate.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/pci_root.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-pm/drivers/acpi/pci_root.c
===================================================================
--- linux-pm.orig/drivers/acpi/pci_root.c
+++ linux-pm/drivers/acpi/pci_root.c
@@ -525,6 +525,7 @@ static int acpi_pci_root_add(struct acpi
dev_err(&device->dev,
"Bus %04x:%02x not present in PCI namespace\n",
root->segment, (unsigned int)root->secondary.start);
+ device->driver_data = NULL;
result = -ENODEV;
goto end;
}
next prev parent reply other threads:[~2013-11-13 23:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 23:14 [PATCH 0/3] ACPI hotplug fixes for 3.13 Rafael J. Wysocki
2013-11-13 23:15 ` [PATCH 1/3] ACPI / hotplug: Fix acpi_bus_get_device() return value check Rafael J. Wysocki
2013-11-18 18:03 ` Toshi Kani
2013-11-13 23:16 ` [PATCH 2/3] ACPI / hotplug: Fix PCI host bridge hot removal Rafael J. Wysocki
2013-11-18 18:10 ` Toshi Kani
2013-11-18 21:39 ` Rafael J. Wysocki
2013-11-18 23:13 ` Toshi Kani
2013-11-19 17:48 ` Toshi Kani
2013-11-19 21:10 ` Rafael J. Wysocki
2013-11-19 21:58 ` Toshi Kani
2013-11-19 23:42 ` Rafael J. Wysocki
2013-11-20 0:08 ` Rafael J. Wysocki
2013-11-20 1:22 ` Toshi Kani
2013-11-20 11:56 ` Rafael J. Wysocki
2013-11-20 15:36 ` Toshi Kani
2013-11-13 23:17 ` Rafael J. Wysocki [this message]
2013-11-18 18:10 ` [PATCH 3/3] ACPI / PCI root: Clear driver_data before failing enumeration Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6884617.gWRuZsFG3E@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=toshi.kani@hp.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).